[Sharethrough] Adapter fixes #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Oct 22, 2019
| @@ -71,7 +71,6 @@ func (s StrOpenRTBTranslator) requestFromOpenRTB(imp openrtb.Imp, request *openr | |||
| headers := http.Header{} | |||
| headers.Add("Content-Type", "application/json;charset=utf-8") | |||
| headers.Add("Accept", "application/json") | |||
| headers.Add("Accept-Encoding", "gzip") | |||
There was a problem hiding this comment.
Curious, why is gzip no longer accepted?
There was a problem hiding this comment.
@SyntaxNode it actually broke our adapter, our ad server now returns gzip encoded responses and it looks like the adapter needs to handle unzipping itself. We'll push a fix later to decode gzipped responses but for now we just need this fix asap in production as it can't process any bid in its current state.
SyntaxNode
approved these changes
Oct 22, 2019
|
Hi @guscarreon, just a heads up we would really appreciate it if this makes it into this week's release as our adapter is broken in its current state. Thank you very much. |
hhhjort
approved these changes
Oct 24, 2019
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* Get bidfloor value from ExtImp instead of Imp [#168939771] * Bump adapter version to 7 * Remove gzip encoding handling (not working)
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* Get bidfloor value from ExtImp instead of Imp [#168939771] * Bump adapter version to 7 * Remove gzip encoding handling (not working)
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* Get bidfloor value from ExtImp instead of Imp [#168939771] * Bump adapter version to 7 * Remove gzip encoding handling (not working)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of fixes:
bidfloorfrom custom impression paramsgzipheader