Rename pbs_light.go To main.go #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
commented
Oct 15, 2019
| glog.Errorf("prebid-server failed: %v", err) | ||
| } | ||
| } | ||
|
|
||
| func loadConfig() (*config.Configuration, error) { |
There was a problem hiding this comment.
Moved the Viper setup logic into its own method to mirror the encapsulation of the server setup. IMHO, this seems easier to read.
| if err := serve(Rev, cfg); err != nil { | ||
|
|
||
| err = serve(Rev, cfg) | ||
| if err != nil { |
There was a problem hiding this comment.
The call to loadConfig cannot be inlined within the if block since the cfg is needed outside the block. Changing the usage of the server call to match for (hopefully you'll agree) improved readability.
| func serve(revision string, cfg *config.Configuration) error { | ||
| currencyConverter := currencies.NewRateConverter(&http.Client{}, cfg.CurrencyConverter.FetchURL, time.Duration(cfg.CurrencyConverter.FetchIntervalSeconds)*time.Second) |
There was a problem hiding this comment.
This line was quite long. Pulled out the time conversion.
mansinahar
approved these changes
Oct 16, 2019
mansinahar
pushed a commit
to mansinahar/prebid-server
that referenced
this pull request
Nov 1, 2019
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common for the main func to be contained within main.go. I understand the pbs_light name is an artifact of an earlier phase of the project. I suggest renaming the app entry point for clarity.