verizonmedia: override tag ID and site ID + split up multi-imp requests #1050
Conversation
| } | ||
| /* Always override the tag ID and site ID of the request */ | ||
| request.Imp[0].TagID = extension.Pos | ||
| request.Site.ID = extension.Dcn |
There was a problem hiding this comment.
you are missing the banner size properties latest changes that we added.
| err := json.Unmarshal(imp.Ext, &bidderExt) | ||
| if err != nil { | ||
| err = &errortypes.BadInput{ | ||
| Message: "ext.bidder not provided", |
There was a problem hiding this comment.
the Imp range index can be added in the error message
| Message: "Missing param dcn", | ||
| if verizonMediaExt.Dcn == "" { | ||
| err = &errortypes.BadInput{ | ||
| Message: "Missing param dcn", |
There was a problem hiding this comment.
the Imp range index can be added in the error message
| Message: "Missing param pos", | ||
| if verizonMediaExt.Pos == "" { | ||
| err = &errortypes.BadInput{ | ||
| Message: "Missing param pos", |
Aadeshp
force-pushed
the
verizonmedia_populate_tag_and_site
branch
2 times, most recently
from
16c1ed4 to
90ea09b
Compare
|
@oath-jac addressed all the comments |
Aadeshp
force-pushed
the
verizonmedia_populate_tag_and_site
branch
2 times, most recently
from
dc73af9 to
f0a1c4b
Compare
| headers.Add("x-openrtb-version", "2.5") | ||
| if err := changeRequestForBidService(&reqCopy, &verizonMediaExt); err != nil { | ||
| errors = append(errors, err) | ||
| return nil, errors |
There was a problem hiding this comment.
@Aadeshp , are we sure we want to return because this particular Imp does not pass the checks found in changeRequestForBidService()? Don't we want to continue instead? The changeRequestForBidService() function pretty much makes sure this Imp is a banner and check for its dimensions. Are sure we want to exit at the first non banner or non-properly dimensioned banner we find?
Aadeshp
force-pushed
the
verizonmedia_populate_tag_and_site
branch
from
f0a1c4b to
df24e68
Compare
| headers.Add("x-openrtb-version", "2.5") | ||
|
|
||
| if request.Device != nil { | ||
| headers.Set("User-Agent", request.Device.UA) |
There was a problem hiding this comment.
Probably wanna check the value of Device.UA before setting the header to make sure it's not empty
Aadeshp
force-pushed
the
verizonmedia_populate_tag_and_site
branch
from
df24e68 to
c3643de
Compare
No description provided.