Add Adpone adapter #1033
Merged
Add Adpone adapter #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guscarreon
previously approved these changes
Sep 20, 2019
|
|
||
| headers := http.Header{} | ||
| headers.Add("Content-Type", "application/json;charset=utf-8") | ||
| requestToBidder := &adapters.RequestData{ |
There was a problem hiding this comment.
Do you think more headers might be helpful? Other adapters include headers such as x-openrtb-version. Do you think it'll help to include more header info?
headers.Add("Accept", "application/json")
headers.Add("x-openrtb-version", "2.5")
There was a problem hiding this comment.
Absolutely yes; I will add more headers. Thanks a lot
guscarreon
requested changes
Sep 23, 2019
static/bidder-info/adpone.yaml
Outdated
| - banner | ||
| site: | ||
| mediaTypes: | ||
| - banner |
There was a problem hiding this comment.
Can you add a newline in here?
static/bidder-params/adpone.json
Outdated
| "title": "Adpone Adapter Params", | ||
| "description": "A schema which validates params accepted by the adpone adapter", | ||
| "type": "object", | ||
| "properties": {}, |
There was a problem hiding this comment.
Are we sure we don't have any parameters we want to check for? If not, do you think you'll need them in the future?
There was a problem hiding this comment.
Probably in the future we will need some parameters so I have added one (placementId). Thanks!
guscarreon
requested changes
Sep 25, 2019
adapters/adpone/adpone.go
Outdated
| requestsToBidder []*adapters.RequestData, | ||
| errs []error, | ||
| ) { | ||
| var imp = &openRTBRequest.Imp[0] |
There was a problem hiding this comment.
When a request with an empty openRTBRequest.Imp array comes in, your adapter fails with an "index out of range" error in line 29. Can we check for nil before dereferencing the Imp array and check its length before accessing any of its elements?
guscarreon
approved these changes
Sep 26, 2019
hhhjort
approved these changes
Oct 1, 2019
mansinahar
pushed a commit
to mansinahar/prebid-server
that referenced
this pull request
Nov 1, 2019
* adpone adapter * adpone adapter * go fmt files * fix typo * remove extra information from req * fix testing * fix usersync_test * add adpone json schema * add adpone to syncer_test.go * add adpone to syncer.go * Add extra headers + return error if no impresison in the bid request * add optional placementId param * remove imp_adpone.go * fix adpone.json * remove some headers * added placementId as optional parameter * go fmt files * fix index out of ragne
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
* adpone adapter * adpone adapter * go fmt files * fix typo * remove extra information from req * fix testing * fix usersync_test * add adpone json schema * add adpone to syncer_test.go * add adpone to syncer.go * Add extra headers + return error if no impresison in the bid request * add optional placementId param * remove imp_adpone.go * fix adpone.json * remove some headers * added placementId as optional parameter * go fmt files * fix index out of ragne
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
* adpone adapter * adpone adapter * go fmt files * fix typo * remove extra information from req * fix testing * fix usersync_test * add adpone json schema * add adpone to syncer_test.go * add adpone to syncer.go * Add extra headers + return error if no impresison in the bid request * add optional placementId param * remove imp_adpone.go * fix adpone.json * remove some headers * added placementId as optional parameter * go fmt files * fix index out of ragne
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
* adpone adapter * adpone adapter * go fmt files * fix typo * remove extra information from req * fix testing * fix usersync_test * add adpone json schema * add adpone to syncer_test.go * add adpone to syncer.go * Add extra headers + return error if no impresison in the bid request * add optional placementId param * remove imp_adpone.go * fix adpone.json * remove some headers * added placementId as optional parameter * go fmt files * fix index out of ragne
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.