Add LockerDome bid adapter #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansinahar
reviewed
Sep 10, 2019
openrtb_ext/imp_lockerdome.go * Delete unnecessary file adapters/lockerdome/lockerdome.go * Better error message for unmarshaling LockerDome bid response * Inline bidsCapacity * Move const unexpectedStatusCodeMessage to top adapters/lockerdome/lockerdometest/exemplary/simple-banner.json * Better error message for unmarshaling LockerDome bid response adapters/lockerdome/lockerdometest/exemplary/simple-banner-multiple.json * Add test case w/ multiple banner requests config/config.go * Inline lockerDomePlatformID
|
Thank you for your feedback, I've just pushed up changes. |
mansinahar
previously approved these changes
Sep 17, 2019
guscarreon
requested changes
Sep 18, 2019
There was a problem hiding this comment.
Validation of all elements in openRTBRequest.Imp[] is needed. Try to keep coverage high after validation is added, 93 to 95 percent is pretty good.
╰─➤ go test -coverprofile=c.out
PASS
coverage: 93.3% of statements
ok github.com/prebid/prebid-server/adapters/lockerdome 0.029s
╰─➤ go tool cover -func=c.out
github.com/prebid/prebid-server/adapters/lockerdome/lockerdome.go:21: MakeRequests 81.8%
github.com/prebid/prebid-server/adapters/lockerdome/lockerdome.go:54: MakeBids 100.0%
github.com/prebid/prebid-server/adapters/lockerdome/lockerdome.go:94: NewLockerDomeBidder 100.0%
github.com/prebid/prebid-server/adapters/lockerdome/usersync.go:10: NewLockerDomeSyncer 100.0%
total: (statements) 93.3%
guscarreon
requested changes
Sep 20, 2019
guscarreon
requested changes
Sep 24, 2019
guscarreon
approved these changes
Sep 24, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
mansinahar
approved these changes
Oct 1, 2019
|
Yay! Thank you! |
mansinahar
pushed a commit
to mansinahar/prebid-server
that referenced
this pull request
Nov 1, 2019
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.