Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortening the query string params, adding BIDID macro #1006

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

bretg
Copy link
Contributor

@bretg bretg commented Aug 19, 2019

The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are:

  • shortening query string params to one char
  • removed the bidder param
  • added BIDID as a macro to hb_winurl

Original version is at https://github.com/prebid/prebid-server/files/2946568/Prebid.Server.Event.Notifications.-.Tech.Spec.pdf

The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are:
- shortening query string params to one char
- removed the bidder param
- added BIDID as a macro to hb_winurl
@bretg bretg requested a review from hhhjort August 19, 2019 17:08
@guscarreon guscarreon self-requested a review August 20, 2019 19:24
@guscarreon guscarreon self-assigned this Aug 20, 2019
@stale
Copy link

stale bot commented Aug 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 27, 2019
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In the "New endpoint" section in the first page it says the GET endpoint will allow web browsers to notify about different ad events. Shouldn't it say to "be notified"? In a GET endpoint they'll pull the information, not push it.
  • Shouldn't this document describe the difference between the win and view events?
  • If this is a GET endpoint, why does the 200 endpoint is understood as the event notification being accepted and delivered for processing? Doesn't that sort of action correspond to a POST endpoint?
  • "Description" section first paragraph seems to have an extra newline.

@stale stale bot removed the stale label Aug 28, 2019
@guscarreon guscarreon assigned hhhjort and unassigned guscarreon Aug 28, 2019
@stale
Copy link

stale bot commented Sep 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 4, 2019
@bretg bretg removed the stale label Sep 4, 2019
@bretg
Copy link
Contributor Author

bretg commented Sep 5, 2019

As for GET-vs-POST. I get your point, but:

  • POSTs cause the browser to do two fetches: OPTIONS and then POST
  • The most common mechanism of dropping a tracking pixel is an 'img src' which is a GET. That's how this endpoint is hit -- img src="pbs.my.com/event/t=win&f=i

So we shouldn't change to POST. Did made some modifications and moved it to github wiki -- https://github.com/prebid/prebid-server/wiki/Prebid-Server-Event-Notification-Tech-Spec

  • changed 'view' event to 'imp' and explained
  • added new column in accounts table in the DB

@hhhjort hhhjort merged commit 3996322 into master Sep 5, 2019
mansinahar pushed a commit to mansinahar/prebid-server that referenced this pull request Nov 1, 2019
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are:
- shortening query string params to one char
- removed the bidder param
- added BIDID as a macro to hb_winurl
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are:
- shortening query string params to one char
- removed the bidder param
- added BIDID as a macro to hb_winurl
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are:
- shortening query string params to one char
- removed the bidder param
- added BIDID as a macro to hb_winurl
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are:
- shortening query string params to one char
- removed the bidder param
- added BIDID as a macro to hb_winurl
@SyntaxNode SyntaxNode deleted the event-tech-spec branch March 13, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants