-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortening the query string params, adding BIDID macro #1006
Conversation
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are: - shortening query string params to one char - removed the bidder param - added BIDID as a macro to hb_winurl
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In the "New endpoint" section in the first page it says the
GET
endpoint will allow web browsers to notify about different ad events. Shouldn't it say to "be notified"? In aGET
endpoint they'll pull the information, not push it. - Shouldn't this document describe the difference between the
win
andview
events? - If this is a
GET
endpoint, why does the 200 endpoint is understood as the event notification being accepted and delivered for processing? Doesn't that sort of action correspond to aPOST
endpoint? - "Description" section first paragraph seems to have an extra newline.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
As for GET-vs-POST. I get your point, but:
So we shouldn't change to POST. Did made some modifications and moved it to github wiki -- https://github.com/prebid/prebid-server/wiki/Prebid-Server-Event-Notification-Tech-Spec
|
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are: - shortening query string params to one char - removed the bidder param - added BIDID as a macro to hb_winurl
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are: - shortening query string params to one char - removed the bidder param - added BIDID as a macro to hb_winurl
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are: - shortening query string params to one char - removed the bidder param - added BIDID as a macro to hb_winurl
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are: - shortening query string params to one char - removed the bidder param - added BIDID as a macro to hb_winurl
The goal is to save on the number of bytes we're sending to the ad server. The differences between this and the original version are:
Original version is at https://github.com/prebid/prebid-server/files/2946568/Prebid.Server.Event.Notifications.-.Tech.Spec.pdf