Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional bid properties: ttl, currency, and netRevenue #237

Closed
snapwich opened this issue Dec 4, 2017 · 8 comments
Closed

Comments

@snapwich
Copy link

snapwich commented Dec 4, 2017

Currently ttl, currency, and netRevenue are not passed through from prebid server, but the prebid server adapter is capable of using them. This is an issue to track support for those properties.

@dbemiller
Copy link
Contributor

dbemiller commented Dec 4, 2017

Currency was also brought up in #226

@hhhjort
Copy link
Collaborator

hhhjort commented Feb 9, 2018

Now that openrtb passes the whole quest through to the adapters, the adapters have the opportunity to act on them. However if not all adapters support the option in question, then the whole response cannot support it. I see a couple of ways we might handle it.

  1. Require bidders to to handle the options, or return no bids if the option exists and they don't handle it. Probably the best solution, but will be hard to enforce without a lot of vigilance. (Who wants to deep dive someone else's adapter to insure currency is handled properly?)
  2. Have the adapters advertise which options they support, so all bidders will only get the options that all the other bidders support for a consistent set of bids.
  3. Do nothing, and leave it on the client side what to do about only a subset of bids supporting certain options.

Between 1 and 2, probably depends on what the spec has to say about the options, if they are ignorable by the bidder or not. 3. is the lazy solution of course.

ttl is a bit different, since the ttl should be enforced by prebid server itself, but the adapters may be able to use knowledge about the time constraints they are under. So 3 would seem to be the proper option here.

@stale
Copy link

stale bot commented Aug 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 8, 2019
@stale stale bot closed this as completed Aug 15, 2019
@bretg bretg removed the stale label Jun 26, 2020
@bretg bretg reopened this Jun 26, 2020
@bretg
Copy link
Contributor

bretg commented Jun 26, 2020

I think we're good on currency now. To cover ttl and netRevenue, I propose we encourage bid adapters to place those values in bidResponse.ext.ttl and bidResponse.ext.netrevenue

@stale
Copy link

stale bot commented Jul 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2020
@bretg bretg added pinned and removed stale labels Sep 2, 2020
@SyntaxNode
Copy link
Contributor

SyntaxNode commented Oct 16, 2020

I think we're good on currency now. To cover ttl and netRevenue, I propose we encourage bid adapters to place those values in bidResponse.ext.ttl and bidResponse.ext.netrevenue

@bretg Are you suggesting bidresponse.ext on the root object or bidresponse.seatbid[].bid[].ext? Specifically, the netRevenue doesn't make sense to us at the top level.

@patmmccann
Copy link
Contributor

TTL now appears covered as well iin the exp field https://github.com/prebid/Prebid.js/pull/5715/files

@bretg
Copy link
Contributor

bretg commented Jul 21, 2022

Closing this issue:

  • currency supported
  • ttl is passed as 'exp' on the response
  • netRevenue was solved with the bidadjustments feature

@bretg bretg closed this as completed Jul 21, 2022
allar15 pushed a commit to allar15/prebid-server that referenced this issue Nov 24, 2023
…rebid#237)

* added type ad to the imp[].ext.storedrequest.id when is HB Group ID

* Optimization function AddTypeAdToHbGroupId

* Optimization function AddTypeAdToHbGroupId - 2

---------

Co-authored-by: mifanich <[email protected]>
StarWindMoonCloud pushed a commit to ParticleMedia/prebid-server that referenced this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants