-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for additional bid properties: ttl, currency, and netRevenue #237
Comments
Currency was also brought up in #226 |
Now that openrtb passes the whole quest through to the adapters, the adapters have the opportunity to act on them. However if not all adapters support the option in question, then the whole response cannot support it. I see a couple of ways we might handle it.
Between 1 and 2, probably depends on what the spec has to say about the options, if they are ignorable by the bidder or not. 3. is the lazy solution of course. ttl is a bit different, since the ttl should be enforced by prebid server itself, but the adapters may be able to use knowledge about the time constraints they are under. So 3 would seem to be the proper option here. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I think we're good on currency now. To cover ttl and netRevenue, I propose we encourage bid adapters to place those values in bidResponse.ext.ttl and bidResponse.ext.netrevenue |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@bretg Are you suggesting |
TTL now appears covered as well iin the exp field https://github.com/prebid/Prebid.js/pull/5715/files |
Closing this issue:
|
…rebid#237) * added type ad to the imp[].ext.storedrequest.id when is HB Group ID * Optimization function AddTypeAdToHbGroupId * Optimization function AddTypeAdToHbGroupId - 2 --------- Co-authored-by: mifanich <[email protected]>
…id huge multi-format placement (prebid#237)
Currently
ttl
,currency
, andnetRevenue
are not passed through from prebid server, but the prebid server adapter is capable of using them. This is an issue to track support for those properties.The text was updated successfully, but these errors were encountered: