-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Bid Support #1715
Comments
Updated based on community feedback:
|
Detailed prebid/prebid-server#1715 Refactor winningBid logic. Added IT test.
docs PR prebid/prebid.github.io#2757 |
Done in PBS-Java 1.59 |
The removal of extra bids has been discussed in slack. Here's a proposed additional clarification/requirement: The focus of the multibid feature is in the definition of the targeting KVPs. However, PBS-Java currently snips off extra bids and that's the way we like it. But PBS-Go's default is to let all extra bids through without KVPs. Which means we either need to debate or make it configurable.
Note: the way this is implemented in PBS-Java is:
|
@bretg What's the rationale behind having both Also, the above spec suggests that |
It was for JSON validation
i.e. if This sort of disappointment is why folks are encouraged to comment during the review period. Yes, I get that it's a lot of work to review the specs and not everyone has time to read all of them. It's also a lot of work to write them. :-). If you strongly object, please open a new issue and we can discuss in PBS committee |
@bsardo asks:
Multibid was all the rage for a bit, but is low priority now. The use case was that certain DSPs wanted their bids to flow all the way through to the ad server. That's it. What I'd personally like to see happen is that we snip off extra bids, but I've accepted that because PBS-Go always returned all bids, that the feature is about targeting.
Yes.
Go and Java config is so divergent at this point it doesn't matter to me. If we do take on a config-consistency project, this will be one of hundreds of options to consider.
Yes, the intention of Req 7 was to have account-level defaults for the request params. It might make sense to also have the 'snipping' config be an account config, but that wasn't mentioned in this issue, so we can save that for the future should it be needed. |
@bretg Bret, can you please confirm what exact result we expect in next use case.
What is expected result?
Another question: if |
I don't know what you mean by 'default_bid_limit'. Perhaps you mean 'default_bid_limit_min'? Here's what requirement 15 says:
So in your example:
Here's what happens:
I admit the name default_bid_limit_min is pretty confusing. I wish people would push back harder when these things are written. |
Thank you for the quick response! Ok, it means code works correct in the PR. Yes, I took the config name from the PR, config/accounts.go :
https://github.com/prebid/prebid-server/blob/d5795e202bc3adf2b2a2abcfe42765be8ed3cfca/config/accounts.go, line 39 |
default_bid_limit is fine. Thanks. |
Thank you! |
Implemented in PBS-Go 0.245.0. |
Copying the Prebid Server-related requirements from prebid/Prebid.js#6317 -- go there for the use cases.
Multi-Bid Requirements
a) The extra bids receive the 'aliased' targets only if ext.prebid.targeting.includebidderkeys is specified and true
The proposed PBS OpenRTB Request enhancement is essentially the same as the PBJS config:
So for example, if a request came in with the above ext.prebid.multibid, and bidderA supplies 3 bids, the system would limit them to the first 2 and the output would look like:
The text was updated successfully, but these errors were encountered: