Small changes after Mansi's review

prebid · Jul 17, 2019 · f0d2976 · f0d2976
1 parent 36e4a6a
commit f0d2976
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/pbsmetrics/config/metrics.go b/pbsmetrics/config/metrics.go
@@ -83,7 +83,7 @@ func (me *MultiMetricsEngine) RecordConnectionClose(success bool) {
 	}
 }
 
-// RecordImps across openRTB2 engines that support the 'Native' Imp type
+//RecordsImps records imps with imp types across all metric engines
 func (me *MultiMetricsEngine) RecordImps(implabels pbsmetrics.ImpLabels) {
 	for _, thisME := range *me {
 		thisME.RecordImps(implabels)

diff --git a/pbsmetrics/prometheus/prometheus.go b/pbsmetrics/prometheus/prometheus.go
@@ -486,15 +486,6 @@ func requestTypesAsString() []string {
 	return output
 }
 
-func impTypesAsString() []string {
-	list := pbsmetrics.ImpTypes()
-	output := make([]string, len(list))
-	for i, s := range list {
-		output[i] = string(s)
-	}
-	return output
-}
-
 func browserTypesAsString() []string {
 	list := pbsmetrics.BrowserTypes()
 	output := make([]string, len(list))