Skip to content

Commit

Permalink
clean-up
Browse files Browse the repository at this point in the history
  • Loading branch information
Gus Carreon committed Sep 11, 2020
1 parent e980036 commit ae39625
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
3 changes: 0 additions & 3 deletions exchange/exchange.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ type ContextKey string

const DebugContextKey = ContextKey("debugInfo")

//type bidResponseExtConfig struct {
// includeDebugInfo, cacheBids, cacheVAST, returnCreative bool
//}
type extCacheInstructions struct {
cacheBids, cacheVAST, returnCreative bool
}
Expand Down
7 changes: 2 additions & 5 deletions exchange/exchange_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ func TestReturnCreativeEndToEnd(t *testing.T) {
}
}

func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or similar to this test
func TestGetBidCacheInfoEndToEnd(t *testing.T) {
testUUID := "CACHE_UUID_1234"
testExternalCacheScheme := "https"
testExternalCacheHost := "www.externalprebidcache.net"
Expand Down Expand Up @@ -508,7 +508,7 @@ func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or
NURL: "",
BURL: "",
LURL: "",
AdM: "<?xml version=\"1.0\" encoding=\"UTF-8\"?><VAST ...></VAST>",
AdM: "",
AdID: "",
ADomain: nil,
Bundle: "",
Expand Down Expand Up @@ -610,7 +610,6 @@ func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or
Seat: string(bidderName),
Bid: []openrtb.Bid{
{
AdM: "<?xml version=\"1.0\" encoding=\"UTF-8\"?><VAST ...></VAST>",
Ext: json.RawMessage(`{ "prebid": { "cache": { "bids": { "cacheId": "` + testUUID + `", "url": "` + testExternalCacheScheme + `://` + testExternalCacheHost + `/` + testExternalCachePath + `?uuid=` + testUUID + `" }, "key": "", "url": "" }`),
},
},
Expand All @@ -634,8 +633,6 @@ func TestGetBidCacheInfoEndToEnd(t *testing.T) { //Test returnCreative here, or
assert.NoErrorf(t, err, "[TestGetBidCacheInfo] Error found while trying to json parse the url field from actual build response. Message: %v \n", err)

assert.Equal(t, expCacheURL, cacheURL, "[TestGetBidCacheInfo] cacheId field in ext should equal \"%s\" \n", expCacheURL)

// compare cache URL
}

func TestBidReturnsCreative(t *testing.T) {
Expand Down

0 comments on commit ae39625

Please sign in to comment.