Omit empty on 'Target json.RawMessage' to avoid sending invalid json …

…in bid request (#968) * Omitempty on 'Target json.RawMessage' to avoid sending invalid in bid request * Omit empty additional fields
prebid · Jul 19, 2019 · 7374057 · 7374057
1 parent 6b20110
commit 7374057
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/adapters/rubicon/rubicon.go b/adapters/rubicon/rubicon.go
@@ -41,8 +41,8 @@ type rubiconParams struct {
 	AccountId int                `json:"accountId"`
 	SiteId    int                `json:"siteId"`
 	ZoneId    int                `json:"zoneId"`
-	Inventory json.RawMessage    `json:"inventory"`
-	Visitor   json.RawMessage    `json:"visitor"`
+	Inventory json.RawMessage    `json:"inventory,omitempty"`
+	Visitor   json.RawMessage    `json:"visitor,omitempty"`
 	Video     rubiconVideoParams `json:"video"`
 }
 
@@ -53,7 +53,7 @@ type rubiconImpExtRPTrack struct {
 
 type rubiconImpExtRP struct {
 	ZoneID int                  `json:"zone_id"`
-	Target json.RawMessage      `json:"target"`
+	Target json.RawMessage      `json:"target,omitempty"`
 	Track  rubiconImpExtRPTrack `json:"track"`
 }
 
@@ -62,7 +62,7 @@ type rubiconImpExt struct {
 }
 
 type rubiconUserExtRP struct {
-	Target json.RawMessage `json:"target"`
+	Target json.RawMessage `json:"target,omitempty"`
 }
 
 type rubiconExtUserTpID struct {

diff --git a/openrtb_ext/bid_response_video.go b/openrtb_ext/bid_response_video.go
@@ -4,7 +4,7 @@ import "encoding/json"
 
 type BidResponseVideo struct {
 	AdPods []*AdPod        `json:"adPods"`
-	Ext    json.RawMessage `json:"ext"`
+	Ext    json.RawMessage `json:"ext,omitempty"`
 }
 
 type AdPod struct {

diff --git a/openrtb_ext/imp_rubicon.go b/openrtb_ext/imp_rubicon.go
@@ -9,8 +9,8 @@ type ExtImpRubicon struct {
 	AccountId int                `json:"accountId"`
 	SiteId    int                `json:"siteId"`
 	ZoneId    int                `json:"zoneId"`
-	Inventory json.RawMessage    `json:"inventory"`
-	Visitor   json.RawMessage    `json:"visitor"`
+	Inventory json.RawMessage    `json:"inventory,omitempty"`
+	Visitor   json.RawMessage    `json:"visitor,omitempty"`
 	Video     rubiconVideoParams `json:"video"`
 }