Refactor TCF 1/2 Vendor List Fetcher Tests (#1441)

prebid · Sep 8, 2020 · 480d2a2 · 480d2a2
1 parent d75df46
commit 480d2a2
Show file tree

Hide file tree

Showing 4 changed files with 851 additions and 413 deletions.
diff --git a/gdpr/gdpr.go b/gdpr/gdpr.go
@@ -29,9 +29,10 @@ type Permissions interface {
 	AMPException() bool
 }
 
+// Versions of the GDPR TCF technical specification.
 const (
-	tCF1 uint8 = 1
-	tCF2 uint8 = 2
+	tcf1SpecVersion uint8 = 1
+	tcf2SpecVersion uint8 = 2
 )
 
 // NewPermissions gets an instance of the Permissions for use elsewhere in the project.
@@ -45,8 +46,8 @@ func NewPermissions(ctx context.Context, cfg config.GDPR, vendorIDs map[openrtb_
 		cfg:       cfg,
 		vendorIDs: vendorIDs,
 		fetchVendorList: map[uint8]func(ctx context.Context, id uint16) (vendorlist.VendorList, error){
-			tCF1: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tCF1),
-			tCF2: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tCF2)},
+			tcf1SpecVersion: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tcf1SpecVersion),
+			tcf2SpecVersion: newVendorListFetcher(ctx, cfg, client, vendorListURLMaker, tcf2SpecVersion)},
 	}
 }