remove mediaType determination based on impression Id.

prebid · Apr 18, 2024 · 3ddde18 · 3ddde18
1 parent 40c8bb8
commit 3ddde18
Show file tree

Hide file tree

Showing 12 changed files with 207 additions and 600 deletions.
diff --git a/adapters/trustedstack/trustedstack.go b/adapters/trustedstack/trustedstack.go
@@ -82,31 +82,12 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co
 
 func getMediaTypeForImp(bid *openrtb2.Bid, imps []openrtb2.Imp) (openrtb_ext.BidType, error) {
 	mediaType, err := getBidMediaTypeFromMtype(bid)
-	if err == nil {
-		return mediaType, nil
-	}
-
-	for _, imp := range imps {
-		if imp.ID == bid.ImpID {
-			switch {
-			case imp.Banner != nil && imp.Video == nil && imp.Audio == nil && imp.Native == nil:
-				mediaType = openrtb_ext.BidTypeBanner
-			case imp.Banner == nil && imp.Video != nil && imp.Audio == nil && imp.Native == nil:
-				mediaType = openrtb_ext.BidTypeVideo
-			case imp.Banner == nil && imp.Video == nil && imp.Audio != nil && imp.Native == nil:
-				mediaType = openrtb_ext.BidTypeAudio
-			case imp.Banner == nil && imp.Video == nil && imp.Audio == nil && imp.Native != nil:
-				mediaType = openrtb_ext.BidTypeNative
-			}
+	if err != nil {
+		return "", &errortypes.BadInput{
+			Message: err.Error(),
 		}
 	}
-
-	if mediaType != "" {
-		return mediaType, nil
-	}
-	return "", &errortypes.BadInput{
-		Message: fmt.Sprintf("Failed to find impression \"%s\"", bid.ImpID),
-	}
+	return mediaType, nil
 }
 
 func getBidMediaTypeFromMtype(bid *openrtb2.Bid) (openrtb_ext.BidType, error) {

diff --git a/adapters/trustedstack/trustedstacktest/exemplary/multi-imps.json b/adapters/trustedstack/trustedstacktest/exemplary/multi-imps.json
@@ -100,7 +100,8 @@
                                     "adm": "some-test-ad",
                                     "crid": "test-crid",
                                     "h": 50,
-                                    "w": 320
+                                    "w": 320,
+                                    "mtype": 1
                                 }
                             ]
                         }
@@ -123,7 +124,8 @@
                         "adm": "some-test-ad",
                         "crid": "test-crid",
                         "w": 320,
-                        "h": 50
+                        "h": 50,
+                        "mtype": 1
                     },
                     "type": "banner"
                 }

diff --git a/adapters/trustedstack/trustedstacktest/exemplary/simple-audio-mtype.json b/adapters/trustedstack/trustedstacktest/exemplary/simple-audio-mtype.json
diff --git a/adapters/trustedstack/trustedstacktest/exemplary/simple-audio.json b/adapters/trustedstack/trustedstacktest/exemplary/simple-audio.json
@@ -60,7 +60,8 @@
                   "impid": "1",
                   "price": 2.50,
                   "adm": "some-test-ad",
-                  "crid": "test-crid"
+                  "crid": "test-crid",
+                  "mtype": 3
                 }
               ]
             }
@@ -79,7 +80,8 @@
             "impid": "1",
             "price": 2.50,
             "adm": "some-test-ad",
-            "crid": "test-crid"
+            "crid": "test-crid",
+            "mtype": 3
           },
           "type": "audio"
         }

diff --git a/adapters/trustedstack/trustedstacktest/exemplary/simple-banner-mtype.json b/adapters/trustedstack/trustedstacktest/exemplary/simple-banner-mtype.json