-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TheMediaGrid fix bug with wrong type in response #1725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rong_type # Conflicts: # src/main/java/org/prebid/server/bidder/grid/GridBidder.java
yevhenii-viktorov
suggested changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider minor changes, other then that, looks good
src/main/java/org/prebid/server/bidder/grid/model/responce/GridBid.java
Outdated
Show resolved
Hide resolved
yevhenii-viktorov
previously approved these changes
Feb 18, 2022
And1sS
force-pushed
the
grid/fix_bug_with_wrong_type
branch
from
February 21, 2022 11:46
6068ae7
to
062c657
Compare
CTMBNara
previously approved these changes
Feb 22, 2022
…to grid/fix_bug_with_wrong_type # Conflicts: # src/main/java/org/prebid/server/bidder/grid/GridBidder.java # src/test/java/org/prebid/server/bidder/grid/GridBidderTest.java
marki1an
requested review from
yevhenii-viktorov and
CTMBNara
and removed request for
CTMBNara
February 22, 2022 13:48
And1sS
requested changes
Feb 22, 2022
src/test/java/org/prebid/server/bidder/grid/GridBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/grid/GridBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/grid/GridBidderTest.java
Outdated
Show resolved
Hide resolved
And1sS
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebid/prebid-server#2114