Bugfix: Skip Auction logic revert (#3324)

prebid · Jul 24, 2024 · 9505a8f · 9505a8f
1 parent 28574b5
commit 9505a8f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/src/main/java/org/prebid/server/auction/SkippedAuctionService.java b/src/main/java/org/prebid/server/auction/SkippedAuctionService.java
@@ -1,7 +1,6 @@
 package org.prebid.server.auction;
 
 import com.iab.openrtb.request.BidRequest;
-import com.iab.openrtb.response.BidResponse;
 import com.iab.openrtb.response.SeatBid;
 import io.vertx.core.Future;
 import org.apache.commons.collections4.CollectionUtils;
@@ -33,8 +32,7 @@ public SkippedAuctionService(StoredResponseProcessor storedResponseProcessor,
 
     public Future<AuctionContext> skipAuction(AuctionContext auctionContext) {
         if (auctionContext.isRequestRejected()) {
-            return Future.succeededFuture(auctionContext.with(
-                    BidResponse.builder().seatbid(Collections.emptyList()).build()));
+            return Future.failedFuture("Rejected request cannot be skipped");
         }
 
         final ExtStoredAuctionResponse storedResponse = Optional.ofNullable(auctionContext.getBidRequest())

diff --git a/src/test/java/org/prebid/server/auction/SkippedAuctionServiceTest.java b/src/test/java/org/prebid/server/auction/SkippedAuctionServiceTest.java
@@ -59,10 +59,8 @@ public void skipAuctionShouldReturnFailedFutureWhenRequestIsRejected() {
         final Future<AuctionContext> result = target.skipAuction(givenAuctionContext);
 
         // then
-        assertThat(result.succeeded()).isTrue();
-        final BidResponse expectedBidResponse = BidResponse.builder().seatbid(emptyList()).build();
-        assertThat(result.result()).isEqualTo(givenAuctionContext.with(expectedBidResponse));
-
+        assertThat(result.failed()).isTrue();
+        assertThat(result.cause()).hasMessage("Rejected request cannot be skipped");
         verifyNoInteractions(storedResponseProcessor, bidResponseCreator);
     }