IntentIQ ID System: added enableCookieStorage optional parameter #9987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
The code looks good, but I'd like to see some tests that ensure the functionality works. |
Thanks for the feedback! The tests are now added. |
|
Is there anything else that is missing in this PR? |
|
apologies for the delay - I was on holiday and didn't see the update. It looks like there's a merge conflict now, but once you resolve that I will merge right away. |
smenzer
approved these changes
Jun 21, 2023
|
Unfortunately was unable solve conflicts on the same PR |
|
closing in favor of #10145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Added a new parameter called
enableCookieStorageto control the cookie storage.Other information
PR in Prebid Docs: prebid/prebid.github.io#4595