Tappx Bid Adapter: accept ortb2 country #9907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from original branch
10207: Include setConfig Geo function and intruccions in Readme file
patmmccann
requested changes
May 6, 2023
patmmccann
reviewed
May 6, 2023
patmmccann
changed the title
please add unit tests
|
@prebidtappx please add unit tests here to make sure we haven't broken you. |
patmmccann
approved these changes
Jul 26, 2023
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
* Fix: creating host correctly when http or https are added from the beginning * Fix :: Changed double quotes for single quotes * Fix :: Getting the full page URL * Fix :: Changed order params * Fix :: Replaced quotes from double to simple * Fix :: Adapting format to lint * Remove TODO comment * Added more controls * camelcase fix * Changed test * Remove "inIframe" util * Fix: solved error getOs and created getVendor functions * Fix: Solved CircelCI format problems * 10207_include setConfig function and intruccions in readme file * Update tappxBidAdapter.md * Update tappxBidAdapter.js * Fix: repriorising to get the OS correctly * Fix: Correcting EsLint requirements for merge * Update tappxBidAdapter.js please add unit tests --------- Co-authored-by: Jordi Arnau <[email protected]> Co-authored-by: ruben_tappx <[email protected]> Co-authored-by: jgarciaorad <[email protected]> Co-authored-by: Patrick McCann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Changes related to issue #9676 accepting Geo data (more precisely Country) from ORTB2 first-party data.
Other information
Related issue #9676