Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidWatch Analytics Adapter - change name #9101

Closed
wants to merge 2 commits into from
Closed

bidWatch Analytics Adapter - change name #9101

wants to merge 2 commits into from

Conversation

matthieularere-msq
Copy link
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

This PR rename files and variables from bidwatch Analytics Adapter to oxxion Analytics Adapter

@ChrisHuie
Copy link
Collaborator

@matthieularere-msq we are unable to change the name of your adapter until a major release since it would break current implementations on upgrade. Not sure we are releasing a new version until early next year though?

@matthieularere-msq
Copy link
Contributor Author

@ChrisHuie Thanks, I expected such a feedback. If I wish this change to be done before the next major release, should I create a new module with the new name and later on ask to delete the old one ?

@muuki88
Copy link
Collaborator

muuki88 commented Oct 31, 2022

Docs PR: prebid/prebid.github.io#4069

@ChrisHuie
Copy link
Collaborator

@ChrisHuie Thanks, I expected such a feedback. If I wish this change to be done before the next major release, should I create a new module with the new name and later on ask to delete the old one ?

Talked with some folks on this and you could create the newly named adapter and import the bidWatch one. Then just deprecate bidwatch on major release and move the code? Or you could create a totally separate new adapter and deprecate the other on major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants