Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoossp and Aol Bid Adapters: Added epsilon.com user id source #9096

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

radubarbos
Copy link
Contributor

Type of change

  • Bugfix

  • [ x] Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

@slimkrazy
Copy link
Contributor

Thanks @radubarbos - all good.

@slimkrazy
Copy link
Contributor

Actually - one thing. We've allowed these two to get slightly out-of sync. Can you take the list of supported EIDs from the newer bid adapter and copy it across to the legacy adapter?

@patmmccann
Copy link
Collaborator

Please cover with a test

@patmmccann patmmccann changed the title Module: Change Added epsilon.com user id source to yahoossp and aol bid adapters. yahoossp and aol bid adapters: Change Added epsilon.com user id source Oct 11, 2022
@patmmccann patmmccann changed the title yahoossp and aol bid adapters: Change Added epsilon.com user id source yahoossp and aol bid adapters: Added epsilon.com user id source Oct 11, 2022
@radubarbos
Copy link
Contributor Author

Added unit test that checks the epsilon.com eids source among others.

@ChrisHuie ChrisHuie self-requested a review October 13, 2022 14:24
@ChrisHuie ChrisHuie self-assigned this Oct 13, 2022
@ChrisHuie ChrisHuie changed the title yahoossp and aol bid adapters: Added epsilon.com user id source Yahoossp and Aol Bid Adapters: Added epsilon.com user id source Oct 13, 2022
@ChrisHuie ChrisHuie merged commit eb00d83 into prebid:master Oct 13, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…id#9096)

* Added epsilon.com user id source to yahoossp and aol bid adapters.

* Added epsilon.com user id source to yahoossp and aol bid adapters- unit test.

* Added epsilon.com user id source to yahoossp and aol bid adapters- unit test.

Co-authored-by: dumitrubarbos <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…id#9096)

* Added epsilon.com user id source to yahoossp and aol bid adapters.

* Added epsilon.com user id source to yahoossp and aol bid adapters- unit test.

* Added epsilon.com user id source to yahoossp and aol bid adapters- unit test.

Co-authored-by: dumitrubarbos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants