Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AndBeyond.Media adapter: update bidder code #9005

Merged
merged 9 commits into from
Oct 6, 2022
Merged

AndBeyond.Media adapter: update bidder code #9005

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1aa646d
add andBeyondMedia adapter
AndBeyondMediaHB Jul 12, 2022
61275e7
update bidderCode
AndBeyondMediaHB Jul 29, 2022
957a46a
Merge remote-tracking branch 'prebid/master'
AndBeyondMediaHB Sep 16, 2022
7f49497
update biddercode
AndBeyondMediaHB Sep 16, 2022
e149379
change andbeyond.media => andbeyond
vladis-teqblaze Sep 19, 2022
254e9b7
changes
AndBeyondMediaHB Sep 27, 2022
2016dec
updates
AndBeyondMediaHB Sep 27, 2022
eeb2a1a
rename files
AndBeyondMediaHB Sep 29, 2022
166b02e
updates
AndBeyondMediaHB Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/andBeyondMediaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { config } from '../src/config.js';

const BIDDER_CODE = 'beyondmedia';
const BIDDER_CODE = 'andbeyond.media';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very long, why not andbeyond

Copy link
Collaborator

@patmmccann patmmccann Sep 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also breaking i believe, add your old code as an alias

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very long, why not andbeyond

The thing is that this is a full name of the Company and we cannot shorten this to andbeyond. I haven't seen any limitations before. Do you have any?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GAM key values have a limit of 20 chars. And GET requests have a length limit. This can cause issues for publishers which use enableSendAll key values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann @muuki88
We have changed the code to "andbeyond". This is fine ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann @muuki88 we noticed that biddercode andbeyond is an Adkernel adapter alias, is that normal?https://github.com/AndBeyondMediaHB/Prebid.js/blob/master/modules/adkernelBidAdapter.js#L82

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann @muuki88
image

Are these rules valid? If so, can we use the biddercode andbeyondmedia. If not, why not?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well in this case you would not be unique with adkernel's alias for the first 6 characters. Did you discover why they are using your name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann They are using this name because this is a name of their company, they cannot change it to another one. Could you please clarify if it can cause some problems when this is not unique with adkernel's alias?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdKernel's company name is also andbeyond?

const AD_URL = 'https://backend.andbeyond.media/pbjs';
const SYNC_URL = 'https://cookies.andbeyond.media';

Expand Down
6 changes: 3 additions & 3 deletions modules/andBeyondMediaBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ AndBeyond.Media bid adapter supports Banner, Video (instream and outstream) and
},
bids: [
{
bidder: 'beyondmedia',
bidder: 'andbeyond.media',
params: {
placementId: 'testBanner',
}
Expand All @@ -43,7 +43,7 @@ AndBeyond.Media bid adapter supports Banner, Video (instream and outstream) and
},
bids: [
{
bidder: 'beyondmedia',
bidder: 'andbeyond.media',
params: {
placementId: 'testVideo',
}
Expand All @@ -68,7 +68,7 @@ AndBeyond.Media bid adapter supports Banner, Video (instream and outstream) and
},
bids: [
{
bidder: 'beyondmedia',
bidder: 'andbeyond.media',
params: {
placementId: 'testNative',
}
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/andBeyondMediaBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { spec } from '../../../modules/andBeyondMediaBidAdapter.js';
import { BANNER, VIDEO, NATIVE } from '../../../src/mediaTypes.js';
import { getUniqueIdentifierStr } from '../../../src/utils.js';

const bidder = 'beyondmedia'
const bidder = 'andbeyond.media'

describe('AndBeyondMediaBidAdapter', function () {
const bids = [
Expand Down