Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: upgrade gulp-eslint to 6.0.0 #8976

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

musikele
Copy link
Contributor

@musikele musikele commented Sep 9, 2022

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Code style update (formatting, local variables)

  • [ X ] Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

In order to use javascript operator ??, we need to upgrade gulp-eslint.

Other information

The need for this PR came from LiveIntent PR 8960

Example output:

➜  Prebid.js git:(upgrade_eslint) ✗ npx gulp lint 
[15:05:26] Using gulpfile ~/Documents/code/magnite/Prebid.js/gulpfile.js
[15:05:26] Starting 'lint'...
[15:06:09] Finished 'lint' after 43 s

When something is wrong, errors are still being reported:

➜  Prebid.js git:(upgrade_eslint) ✗ npx gulp lint
[15:08:03] Using gulpfile ~/Documents/code/magnite/Prebid.js/gulpfile.js
[15:08:03] Starting 'lint'...
[15:08:46] 
/Users/mnasti/Documents/code/magnite/Prebid.js/src/prebid.js
  27:5  error  'evil' is defined but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

[15:08:46] 'lint' errored after 43 s
[15:08:46] ESLintError in plugin "gulp-eslint"
Message:
    Failed with 1 error
Details:
    domainEmitter: [object Object]
    domainThrown: false

@musikele musikele self-assigned this Sep 9, 2022
@ChrisHuie ChrisHuie self-requested a review September 9, 2022 13:10
@ChrisHuie ChrisHuie added the dependencies Pull requests that update a dependency file label Sep 9, 2022
@ChrisHuie ChrisHuie changed the title upgrade gulp-eslint to 6.0.0 Dependencies: upgrade gulp-eslint to 6.0.0 Sep 9, 2022
@ChrisHuie ChrisHuie assigned ChrisHuie and unassigned musikele Sep 9, 2022
@patmmccann patmmccann merged commit b04c132 into master Sep 9, 2022
@patmmccann patmmccann deleted the upgrade_eslint branch September 9, 2022 14:19
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants