Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubmatic bid adapter: improved site object handling #8820

Merged
merged 5 commits into from
Aug 15, 2022
Merged

Pubmatic bid adapter: improved site object handling #8820

merged 5 commits into from
Aug 15, 2022

Conversation

pm-nitin-shirsat
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Now, site.page, site.domain and site.ref can not be overwritten by the publisher in the ortb2 object by setting the config.

@patmmccann patmmccann changed the title Ns feat stop overwriting site Pubmatic bid adapter: improved site object handling Aug 11, 2022
@patmmccann patmmccann self-assigned this Aug 11, 2022
@ChrisHuie
Copy link
Collaborator

@pm-nitin-shirsat can you pull in recent commits to this pr. Seems to be a little behind master.

@patmmccann patmmccann merged commit 9eda78a into prebid:master Aug 15, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@pm-nitin-shirsat @JacobKlein26
Pubmatic bid adapter: improved site object handling (prebid#8820)
a3d8ad5 
* UOE-7836: Vanilla JS: Stop overwriting site.page site.ref and site.domain

* UOE-7836: Vanilla JS: Stop overwriting site.page site.ref and site.domain in PrebidServerBidAdapter

* Rename variable name

* Revert changes from PrebidServerBidAdapter file

* Test cases written for the ticket UOE-7666 - stop overriding page, domain, site
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@pm-nitin-shirsat @jorgeluisrocha
Pubmatic bid adapter: improved site object handling (prebid#8820)
e597bbe 
* UOE-7836: Vanilla JS: Stop overwriting site.page site.ref and site.domain

* UOE-7836: Vanilla JS: Stop overwriting site.page site.ref and site.domain in PrebidServerBidAdapter

* Rename variable name

* Revert changes from PrebidServerBidAdapter file

* Test cases written for the ticket UOE-7666 - stop overriding page, domain, site
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pm-nitin-shirsat @ChrisHuie @patmmccann