Criteo Adapter: remove bid.adId #8783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 86c82fd740f1a43b4049e48285417c317c680249 into c2036db - view on LGTM.com new alerts:
|
|
please note the introduced lgtm alert |
patmmccann
requested changes
Aug 4, 2022
patmmccann
reviewed
Aug 4, 2022
| @@ -235,7 +235,6 @@ export const spec = { | |||
| const bidId = bidRequest.bidId; | |||
| const bid = { | |||
| requestId: bidId, | |||
| adId: slot.bidId || getUniqueIdentifierStr(), | |||
There was a problem hiding this comment.
please remove imprt of getUniqueIdentifierStr
dzhang-criteo
force-pushed
the
remove-adId
branch
from
86c82fd to
83893aa
Compare
|
I have done the update. |
8 tasks
patmmccann
approved these changes
Aug 4, 2022
|
Related docs PR: |
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removed bid.adId parameter as asked (see #6381)