Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rise bid adapter - support multi seller end points #8771

Merged
merged 45 commits into from
Aug 11, 2022

Conversation

innay
Copy link
Contributor

@innay innay commented Aug 3, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Support multi seller end points - new bidder param rtbDomain which controls the seller end point

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @innay,

Your change looks good. I think since you're adding a new bid param, rtbDomain, its better to update the docs.

@innay
Copy link
Contributor Author

innay commented Aug 7, 2022

Hi @Fawke , Thanks for your review. Added the 'rtbDomain' to the docs

@Fawke
Copy link
Contributor

Fawke commented Aug 8, 2022

Thanks @innay. Can you also create a PR for the public docs? Specifically this file - https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/rise.md.

@innay
Copy link
Contributor Author

innay commented Aug 10, 2022

@Fawke done. prebid/prebid.github.io#3949

@Fawke Fawke self-requested a review August 11, 2022 13:28
@Fawke Fawke merged commit 5289c29 into prebid:master Aug 11, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* support rtbDomain seller end point

* removed hb. from rtbDomain end point

* added rtbDomain to docs

Co-authored-by: Noam Tzuberi <[email protected]>
Co-authored-by: noamtzu <[email protected]>
Co-authored-by: Noam Tzuberi <[email protected]>
Co-authored-by: Laslo Chechur <[email protected]>
Co-authored-by: OronW <[email protected]>
Co-authored-by: lasloche <[email protected]>
Co-authored-by: Inna Yaretsky <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* support rtbDomain seller end point

* removed hb. from rtbDomain end point

* added rtbDomain to docs

Co-authored-by: Noam Tzuberi <[email protected]>
Co-authored-by: noamtzu <[email protected]>
Co-authored-by: Noam Tzuberi <[email protected]>
Co-authored-by: Laslo Chechur <[email protected]>
Co-authored-by: OronW <[email protected]>
Co-authored-by: lasloche <[email protected]>
Co-authored-by: Inna Yaretsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants