Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adquery Bid Adapter: bugfix local uuid #8734

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Adquery Bid Adapter: bugfix local uuid #8734

merged 2 commits into from
Jul 25, 2022

Conversation

adquery
Copy link
Contributor

@adquery adquery commented Jul 25, 2022

Type of change

  • [ x] Bugfix

Description of change

Adquery bugfix - changed uuid generation method. Now we generate it on the server side

@ChrisHuie ChrisHuie changed the title adquery - bugfix local uuid Adquery Bid Adapter: bugfix local uuid Jul 25, 2022
@ChrisHuie ChrisHuie self-requested a review July 25, 2022 11:51
@ChrisHuie ChrisHuie self-assigned this Jul 25, 2022
@ChrisHuie
Copy link
Collaborator

@adquery can you add a unit test to this pr please. Prior unit tests don't seem to cover this update unless Im wrong?

@adquery
Copy link
Contributor Author

adquery commented Jul 25, 2022

hi chrishuie we have test to qid
it('should include qid', function () { expect(rdata.qid).not.be.null })

@ChrisHuie ChrisHuie merged commit 25aa858 into prebid:master Jul 25, 2022
@adquery adquery deleted the adquery-fix-local-uuid branch July 25, 2022 15:59
ccorbo pushed a commit to ccorbo/Prebid.js that referenced this pull request Jul 27, 2022
* adquery - bugfix local uuid

* adquery - bugfix local uuid

Co-authored-by: m.czerwiak <[email protected]>
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* adquery - bugfix local uuid

* adquery - bugfix local uuid

Co-authored-by: m.czerwiak <[email protected]>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* adquery - bugfix local uuid

* adquery - bugfix local uuid

Co-authored-by: m.czerwiak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants