Rubicon Bid Adapter: Do not send storedrequests #8717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
approved these changes
Jul 21, 2022
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* do NOT send stored requests! * set to undefined not delete faster?
ccorbo
pushed a commit
to ccorbo/Prebid.js
that referenced
this pull request
Jul 27, 2022
* do NOT send stored requests! * set to undefined not delete faster?
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* do NOT send stored requests! * set to undefined not delete faster?
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* do NOT send stored requests! * set to undefined not delete faster?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
With prebid moving towards ortb2 stuff, we need to make sure that when a publisher sets a storedrequest for their PBS integration, that we do not mistakingly forward the same one into the rubicon video endpoint (which is a PBS instance in itself). Otherwise, that would be bad!