Impactify Bid Adapter: Remove use of local storage debugging flag #8693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested, we remove the use of local storage. prebid#8689
patmmccann
reviewed
Jul 15, 2022
| // Force impactify debugging parameter | ||
| if (window.localStorage.getItem('_im_db_bidder') != null) { | ||
| request.test = Number(window.localStorage.getItem('_im_db_bidder')); |
There was a problem hiding this comment.
you are welcome to import storageManager and use storage.getDataFromLocalStorage, in this way, deviceAccess controls and gdpr enforcement modules will govern the access
patmmccann
changed the title
patmmccann
changed the title
patmmccann
approved these changes
Jul 15, 2022
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
…693) * Remove use of local storage As requested, we remove the use of local storage. prebid/Prebid.js#8689 * Update impactifyBidAdapter.js
ccorbo
pushed a commit
to ccorbo/Prebid.js
that referenced
this pull request
Jul 27, 2022
…ebid#8693) * Remove use of local storage As requested, we remove the use of local storage. prebid#8689 * Update impactifyBidAdapter.js
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…ebid#8693) * Remove use of local storage As requested, we remove the use of local storage. prebid#8689 * Update impactifyBidAdapter.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, we remove the use of local storage.
#8689