Rubicon Bid Adapter: remove fpd warning #8688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
approved these changes
Jul 14, 2022
harpere
reviewed
Jul 15, 2022
| @@ -1026,8 +1026,6 @@ function applyFPD(bidRequest, mediaType, data) { | |||
| }, []); | |||
| if (segments.length > 0) return segments.toString(); | |||
| }).toString(); | |||
| } else if (typeof prop === 'object' && !Array.isArray(prop)) { | |||
| logWarn('Rubicon: Filtered FPD key: ', key, ': Expected value to be string, integer, or an array of strings/ints'); | |||
There was a problem hiding this comment.
removing this means that execution will now end up in the else if below, and if I'm reading this right, will end up returning prop.toString() when it did not before. What are the repercussions of this? Should keep the above else if and just return nothing?
There was a problem hiding this comment.
Hi @harpere , check this now
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* remove fpd warning * return undefined instead of skipping the if Co-authored-by: Michele Nasti <[email protected]>
ccorbo
pushed a commit
to ccorbo/Prebid.js
that referenced
this pull request
Jul 27, 2022
* remove fpd warning * return undefined instead of skipping the if Co-authored-by: Michele Nasti <[email protected]>
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* remove fpd warning * return undefined instead of skipping the if Co-authored-by: Michele Nasti <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* remove fpd warning * return undefined instead of skipping the if Co-authored-by: Michele Nasti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Remove an unuseful logging.