TheMediaGrid: added ortb2.user.data support to gridNMBidAdapter #8652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
approved these changes
Jul 11, 2022
| @@ -174,9 +181,27 @@ export const spec = { | |||
| user.ext = userExt; | |||
| } | |||
|
|
|||
| const ortb2UserData = deepAccess(bidderRequest, 'ortb2.user.data'); | |||
There was a problem hiding this comment.
You should, at least in intent, be able to just do request = mergeDeep({}, bidderRequest.ortb2, request) instead of merging it piece by piece - if you are intentionally avoiding that I'm interested in understanding why. LGTM otherwise.
There was a problem hiding this comment.
@TheMediaGrid (just tagging for the question above)
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added support of ortb2.user.data and ortb2.site.content.data