Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adtargetme Bid Adapter: initial release #8622

Merged
merged 9 commits into from
Aug 11, 2022

Conversation

tarasmatokhniuk
Copy link
Contributor

@tarasmatokhniuk tarasmatokhniuk commented Jun 29, 2022

Type of change

  • New bidder adapter

Description of change

Adapter for AdserverAdtarget advertising system

  • test parameters for validating bids
const adUnits = [{
    code: 'your-placement',
    mediaTypes: {
            banner: {
                sizes: [[300, 250]]
            }
        },
    bids: [
        {
            bidder: 'adserveradtarget',
            params: {
                sid: 1220291391, // Site/App ID provided from SSP
            }
        }
    ]
}];

Be sure to test the integration with your adserver using the Hello World sample page.

@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2022

This pull request introduces 1 alert when merging 66c2df8 into 2b423e1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

removed unused variable
TEST_MODE_BANNER_SID.
@ChrisHuie
Copy link
Collaborator

@tarasmatokhniuk can you please fix the linting errors in this pr?

@ChrisHuie ChrisHuie changed the title Adtargetme first release Adtargetme Bid Adapter: initial release Jun 30, 2022
@tarasmatokhniuk
Copy link
Contributor Author

@ChrisHuie, is everything ok? what else do i need to do?

@tarasmatokhniuk
Copy link
Contributor Author

Prebid Server requires the first 6 characters of an bidder/adapter name to be unique unless both adapters refer to the same company.
We change prebid js adapter name to be the same as prebid server adapter

add spec for renamed adapter
@ChrisHuie ChrisHuie closed this Jul 13, 2022
@ChrisHuie ChrisHuie reopened this Jul 13, 2022
@ChrisHuie
Copy link
Collaborator

Prebid Server requires the first 6 characters of an bidder/adapter name to be unique unless both adapters refer to the same company. We change prebid js adapter name to be the same as prebid server adapter

@tarasmatokhniuk could you please also submit a pr to our docs repo (https://github.com/prebid/prebid.github.io)?

@tarasmatokhniuk
Copy link
Contributor Author

tarasmatokhniuk commented Jul 14, 2022

import { hasPurpose1Consent } from '../src/utils/gpdr.js';

const INTEGRATION_METHOD = 'prebid.js';
const BIDDER_CODE = 'adserveradtarget';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shorter bidder codes are preferred. Codes over 8 characters get truncated for some targeting keys to gam, eg hb_cache_id_adserveradtarget would truncate to hb_cache_id_adserver.

@tarasmatokhniuk
Copy link
Contributor Author

rename adapter as SyntaxNode advised to prebid server

Copy link
Contributor

@mmoschovas mmoschovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates! lgtm

JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* Adtargetme first release

* fixed unused variable

removed unused variable
TEST_MODE_BANNER_SID.

* fixed CircleCI

* Adtargetme adapter: rename Adtargetme to AdserverAdtarget

* add spec

add spec for renamed adapter

* fixed

* optimize ortb2 data

* Update adtrgtmeBidAdapter.js

* Update adtrgtmeBidAdapter.js
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* Adtargetme first release

* fixed unused variable

removed unused variable
TEST_MODE_BANNER_SID.

* fixed CircleCI

* Adtargetme adapter: rename Adtargetme to AdserverAdtarget

* add spec

add spec for renamed adapter

* fixed

* optimize ortb2 data

* Update adtrgtmeBidAdapter.js

* Update adtrgtmeBidAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants