-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adtargetme Bid Adapter: initial release #8622
Conversation
This pull request introduces 1 alert when merging 66c2df8 into 2b423e1 - view on LGTM.com new alerts:
|
removed unused variable TEST_MODE_BANNER_SID.
@tarasmatokhniuk can you please fix the linting errors in this pr? |
@ChrisHuie, is everything ok? what else do i need to do? |
Prebid Server requires the first 6 characters of an bidder/adapter name to be unique unless both adapters refer to the same company. |
@tarasmatokhniuk could you please also submit a pr to our docs repo (https://github.com/prebid/prebid.github.io)? |
@ChrisHuie It's already there |
import { hasPurpose1Consent } from '../src/utils/gpdr.js'; | ||
|
||
const INTEGRATION_METHOD = 'prebid.js'; | ||
const BIDDER_CODE = 'adserveradtarget'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shorter bidder codes are preferred. Codes over 8 characters get truncated for some targeting keys to gam, eg hb_cache_id_adserveradtarget would truncate to hb_cache_id_adserver.
rename adapter as SyntaxNode advised to prebid server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates! lgtm
* Adtargetme first release * fixed unused variable removed unused variable TEST_MODE_BANNER_SID. * fixed CircleCI * Adtargetme adapter: rename Adtargetme to AdserverAdtarget * add spec add spec for renamed adapter * fixed * optimize ortb2 data * Update adtrgtmeBidAdapter.js * Update adtrgtmeBidAdapter.js
* Adtargetme first release * fixed unused variable removed unused variable TEST_MODE_BANNER_SID. * fixed CircleCI * Adtargetme adapter: rename Adtargetme to AdserverAdtarget * add spec add spec for renamed adapter * fixed * optimize ortb2 data * Update adtrgtmeBidAdapter.js * Update adtrgtmeBidAdapter.js
Type of change
Description of change
Adapter for AdserverAdtarget advertising system
Be sure to test the integration with your adserver using the Hello World sample page.