Kargo Bid Adapter: fixing adm for legacy vast support #8616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoschovas
approved these changes
Jun 29, 2022
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
* kargo adapter - always setting adm for legacy support * kargo adapter - fixing tests
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
* kargo adapter - always setting adm for legacy support * kargo adapter - fixing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Some publishers had previously made changes to accept Vast XML through the
bid.adfield before the Kargo Bid Adapter was populating thebid.vastXmlfield and setting the correctmediaType(changed with #8426).This change will set the
bid.adfield like it did previously while still correctly setting thebid.vastXmlfield for vast ads.