Eplanning Bid Adapter: viewability refactor and fix in search the divs #8610
Conversation
ChrisHuie
changed the title
|
Hi @Rothalack , do you have any ETA for reviewing this? Thanks! |
|
Sorry about that, been crazy busy. This looks good and is working in testing. I'm confused why it didn't get a CircleCI build, I've never seen that before. Do you have an idea why it doesn't have a cci build? |
|
I'm not seeing any other PR's that have done this. My best guess is maybe try to do a master merge and commit that? A commit may trigger the build. |
|
Sure, thanks! We just did a new commit so it should trigger the build |
|
I'm not sure why that's not triggering a build. I've reached out on slack to see if I can get it figured out. |
Kicked off tests 👍 (gave a bit more detail on this issue over slack) |
prebid#8610) * eplanning viewability refactor and fix in search the divs * change observer configuration name * unused variable is removed * kick off circleci tests manually Co-authored-by: Chris Huie <[email protected]>
…s (#8610) * eplanning viewability refactor and fix in search the divs * change observer configuration name * unused variable is removed * kick off circleci tests manually Co-authored-by: Chris Huie <[email protected]>
prebid#8610) * eplanning viewability refactor and fix in search the divs * change observer configuration name * unused variable is removed * kick off circleci tests manually Co-authored-by: Chris Huie <[email protected]>
Type of change
Description of change
eplanning viewability refactor and fix in search the divs
[email protected]