Appnexus Bid Adapter: support native feature flags

[jsnellbaker]

Type of change

• Feature

Description of change

Context for the underlying Feature Flags setting: #8219

Updating the appnexusBidAdapter to support the native-based Feature Flags.

[jsnellbaker]

@dgirardi If you have some time, would you be able to review this initial changes here for our adapter to see if they're correct & proper? I reviewed the original PR and its changes, and I tried to emulate adding the new flag in the parts of the code where we perform native related steps.

From what I could tell, it seemed the flags were only needed where we were doing active changes to auction objects or calling a 'native' function (as opposed to wrapping the underlying native functions themselves where they were defined).

I know there are flags that can be placed in the unit tests, but I wanted to get some feedback on the adapter changes before going to that far.

I ran some build command tests for reference (so it seemed to work):

12033-p-mac:Prebid.js jsnellbaker$ gulp build-bundle-prod > /dev/null 2>&1 && ls -l build/dist/prebid.js
-rw-r--r--  1 jsnellbaker  staff  2382634 Jun 22 10:27 build/dist/prebid.js
12033-p-mac:Prebid.js jsnellbaker$ gulp build-bundle-prod --disable=native> /dev/null 2>&1 && ls -l build/dist/prebid.js
-rw-r--r--  1 jsnellbaker  staff  2368577 Jun 22 10:27 build/dist/prebid.js

12033-p-mac:Prebid.js jsnellbaker$ git stash
Saved working directory and index state WIP on appnexus_native_flags: b74a97fc9 Lasso bid adapter: add new bid adapter (#8503)
12033-p-mac:Prebid.js jsnellbaker$ gulp build-bundle-prod --disable=native> /dev/null 2>&1 && ls -l build/dist/prebid.js
-rw-r--r--  1 jsnellbaker  staff  2373729 Jun 22 10:28 build/dist/prebid.js

Thank you.

[dgirardi]

It looks good to me - and yes, the idea is to tag out use, not definitions (the latter should fail in tests). You can use build-bundle-verbose to see what happens after dead code elimination:

gulp build-bundle-verbose --disable NATIVE

result: https://gist.github.com/dgirardi/23ff993a7e09119eb32de774e8ca0caf

the only two remaining relics I see are:

• supportedMediaTypes still contains NATIVE
• onBidWon is still present, but empty

both should not matter, you could tag them as well but I personally think that's too much ugliness for how much you save out of it.

[jsnellbaker]

@dgirardi Thanks for the initial feedback. I updated the unit tests now - could you take another look? Thanks.