Prebid Core: Implement transaction id on imp.ext.tid #8591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
added
feature
needs 2nd review
dgirardi
reviewed
Jun 21, 2022
| @@ -616,6 +616,27 @@ export const startAuction = hook('async', function ({ bidsBackHandler, timeout: | |||
|
|
|||
| adUnit.transactionId = generateUUID(); | |||
|
|
|||
| // Populate ortb2Imp.ext.tid with transactionId. Specifying a transaction ID per item in the ortb impression array, lets multiple transaction IDs be transmitted in a single bid request. | |||
There was a problem hiding this comment.
I think this whole block could be replaced by
deepSetValue(adUnit, 'ortb2Imp.ext.tid', adUnit.transactionId)
There was a problem hiding this comment.
Nice! Addressed.
| @@ -2200,7 +2200,7 @@ describe('IndexexchangeAdapter', function () { | |||
| expect(diagObj.mfu).to.equal(2); | |||
| expect(diagObj.allu).to.equal(2); | |||
| expect(diagObj.version).to.equal('$prebid.version$'); | |||
| expect(diagObj.url).to.equal('http://localhost:9876/context.html') | |||
| expect(diagObj.url).to.exist | |||
There was a problem hiding this comment.
not sure if I'm OK with this - it should be changed to expect the current port. I believe it's also not the only test that fails when the port chages. In this context I think it'd be better to revert it, and deal with the annoyance of killing stray karma processes until we fix all the tests.
There was a problem hiding this comment.
Yeah this was to avoid failure in the test pipeline when the port is already being used and it gets incremented to 9877.
dgirardi
approved these changes
Jun 21, 2022
patmmccann
changed the title
patmmccann
changed the title
mmoschovas
approved these changes
Jun 22, 2022
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
* add transactionId to openrtb imp ext object * fix unit test * address feedbacks Co-authored-by: shahin.rahbariasl <[email protected]>
jlaso
pushed a commit
to AuDigent/Prebid.js
that referenced
this pull request
Jul 1, 2022
* add transactionId to openrtb imp ext object * fix unit test * address feedbacks Co-authored-by: shahin.rahbariasl <[email protected]>
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
* add transactionId to openrtb imp ext object * fix unit test * address feedbacks Co-authored-by: shahin.rahbariasl <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
Sep 15, 2022
* add transactionId to openrtb imp ext object * fix unit test * address feedbacks Co-authored-by: shahin.rahbariasl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Addresses #8543 (add imp[].ext.tid to openrtb2Imp object).
Tested locally and added unit tests.
Other information
https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/community_extensions/per-imp-tids.md