cpex Id System: Fixes and cleanup, adds eids, changes cookie name #8559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `getId` has to return key `id` to trigger passing the id to bidders - removed unused params - added eids version - renamed cookie to not be mistaken with some Chinese id - not adding the id when cookie is not found - updated tests to match the changes
EskelCz
changed the title
patmmccann
changed the title
|
Please note test failures |
|
@patmmccann Sorry forgot the cookie name change in tests :) Fixed |
|
@jlukas79 Can we please get an estimate when this can be merged? It's a small change concerning just our code. Thanks |
|
@patmmccann Please is there anyone else who can do the review? Should be no work at all I think. |
|
Looks almost done, could you add tests to eids spec file? |
|
@patmmccann Sure, added. Thanks. |
patmmccann
approved these changes
Jun 23, 2022
renebaudisch
pushed a commit
to renebaudisch/Prebid.js
that referenced
this pull request
Jun 28, 2022
…ebid#8559) * Fixes and cleanup, adds eids, changes cookie name - `getId` has to return key `id` to trigger passing the id to bidders - removed unused params - added eids version - renamed cookie to not be mistaken with some Chinese id - not adding the id when cookie is not found - updated tests to match the changes * Fixed tests * Adds eids test for cpexId
jlaso
pushed a commit
to AuDigent/Prebid.js
that referenced
this pull request
Jul 1, 2022
…ebid#8559) * Fixes and cleanup, adds eids, changes cookie name - `getId` has to return key `id` to trigger passing the id to bidders - removed unused params - added eids version - renamed cookie to not be mistaken with some Chinese id - not adding the id when cookie is not found - updated tests to match the changes * Fixed tests * Adds eids test for cpexId
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…ebid#8559) * Fixes and cleanup, adds eids, changes cookie name - `getId` has to return key `id` to trigger passing the id to bidders - removed unused params - added eids version - renamed cookie to not be mistaken with some Chinese id - not adding the id when cookie is not found - updated tests to match the changes * Fixed tests * Adds eids test for cpexId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
getIdhas to return keyidto trigger passing the id to bidders