Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDX Bid Adaper: added new bid adapter #8531

Merged
merged 4 commits into from
Jun 15, 2022
Merged

IDX Bid Adaper: added new bid adapter #8531

merged 4 commits into from
Jun 15, 2022

Conversation

ffqs
Copy link
Contributor

@ffqs ffqs commented Jun 7, 2022

Type of change

  • Bugfix
  • Feature
  • [x ] New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'idx-bidder-code',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title IDX bidder adapter IDX Bid Adaper: add new bid adapter Jun 8, 2022
@ChrisHuie ChrisHuie requested a review from lksharma June 8, 2022 14:53
modules/idxBidAdapter.js Outdated Show resolved Hide resolved
modules/idxBidAdapter.js Outdated Show resolved Hide resolved
modules/idxBidAdapter.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@lksharma lksharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lksharma
Copy link
Collaborator

@ffqs The PR LGTM. You can also open a PR against the headerbid-expert repository to have your adapter recognized by the Headerbid Expert extension.

@lksharma lksharma changed the title IDX Bid Adaper: add new bid adapter IDX Bid Adaper: added new bid adapter Jun 15, 2022
@lksharma lksharma merged commit 5e1c581 into prebid:master Jun 15, 2022
renebaudisch pushed a commit to renebaudisch/Prebid.js that referenced this pull request Jun 28, 2022
* IDX bidder adapter

* integration with BE

* IDX Bid Adapter: change bidder code

* IDX Bid Adapter: change bidder code and remove unnecessary condition
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
* IDX bidder adapter

* integration with BE

* IDX Bid Adapter: change bidder code

* IDX Bid Adapter: change bidder code and remove unnecessary condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants