Lifestreet Bid adapter: initial release

[probably-kira]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Added back Lifestreet adapter with meta properties added

• test parameters for validating bids

{
  bidder: 'lifestreet',
  params: {
        adkey: 'f1c',
        ad_size: '300x250',
        slot: 'slot1227913',
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• Maintainer: [email protected]
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
  Our docs exists: https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/lifestreet.md

Other information

[patmmccann]

please note there are no tests in your file

[probably-kira]

please note there are no tests in your file

oh sorry! can't get how could this happens.. added back

[probably-kira]

@ChrisHuie could you please tell me which kind of update needs to be done? Is it something from my side or from your side? Thanks!

[ChrisHuie]

@ChrisHuie could you please tell me which kind of update needs to be done? Is it something from my side or from your side? Thanks!

Yes. My apologies. Your tests seem to be failing their unit tests per CircleCi.

[probably-kira]

@ChrisHuie sorry for radio silence! I've fixed tests, could you please take a look on this PR?

[probably-kira]

@ChrisHuie additional ping just in case you you missed previous one

[ChrisHuie]

@ChrisHuie additional ping just in case you you missed previous one

Sorry I did. Will work on this review :)

[probably-kira]

@ChrisHuie additional ping just in case you you missed previous one

Sorry I did. Will work on this review :)

any news on this?

[ChrisHuie]

FYI. refererInfo was updated/refactored in Prebid 7 with #8450 . Not sure if you are expecting refererInfo to act as previous versions.

[ChrisHuie]

@probably-kira hoping to get this merged this week or next week. I don't see docs in our docs repo though (https://github.com/prebid/prebid.github.io). If you don't mind submitting a pr over there also to compliment this new adapter code pr. Here is some docs around how the markdown can be easily setup (https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter) :)

[probably-kira]

@probably-kira hoping to get this merged this week or next week. I don't see docs in our docs repo though (https://github.com/prebid/prebid.github.io). If you don't mind submitting a pr over there also to compliment this new adapter code pr. Here is some docs around how the markdown can be easily setup (https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter) :)

hi Chris, I apologize, was on vacation. Will do everything till EOW

[probably-kira]

@ChrisHuie I've checked and here is the file:
https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/lifestreet.md
nothing was changed in request format since that time, so the documentation is valid, but please let me know if I should update it somehow

[probably-kira]

thanks a lot @ChrisHuie!!