Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yahoo user identity module: initial release #7519

Merged
merged 8 commits into from
Oct 15, 2021

Conversation

slimkrazy
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

All things with Verizon Media branding are shifting to the Yahoo brand. A new bid adapter is being prepared by @adam-browning and will soon be in PR, but in the meantime here is the newly branded user identity module.

The plan from the team is to first release the new Yahoo bid adapter - this will consume user ID data from the newly branded UserID module, then in a later release we will drop the old 'aol' adapter and add 'aol' as an alias of the new Yahoo bid adapter (config is the same). At this point we will also remove the old Verizon Media user identity module.

Will update this PR shortly once I open a PR for the documentation site.

@patmmccann patmmccann changed the title Feature/yahoo user identity module Yahoo user identity module: initial release Sep 30, 2021
modules/connectIDSystem.js Outdated Show resolved Hide resolved
test/spec/modules/connectIDSystem_spec.js Outdated Show resolved Hide resolved
Copy link
Contributor

@adam-browning adam-browning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
FYI CircleCI test failing due to 3p adapter "SharedId"

@slimkrazy
Copy link
Contributor Author

@ncolletti - The docs PR is now here: prebid/prebid.github.io#3334

modules/connectIDSystem.js Outdated Show resolved Hide resolved
modules/connectIDSystem.js Outdated Show resolved Hide resolved
modules/connectIDSystem.md Outdated Show resolved Hide resolved
modules/connectIDSystem.js Outdated Show resolved Hide resolved
modules/connectIDSystem.md Outdated Show resolved Hide resolved
@ncolletti
Copy link
Contributor

ncolletti commented Oct 10, 2021

Could you also add your module examples to the following files:

modules/userId/eids.md
modules/userId/userId.md

@slimkrazy
Copy link
Contributor Author

@ncolletti - Any chance this PR can be checked again? With regards to the example, isn't the example found in modules/connectIdSystem.md enough?

Copy link
Contributor

@adam-browning adam-browning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ncolletti
Copy link
Contributor

@slimkrazy It is a small request to add examples to the remaining two markdown files. You also need to add your id module to modules/.submodules.json before this can be approved. Thank you!

Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncolletti ncolletti merged commit 38b9816 into prebid:master Oct 15, 2021
cpabst pushed a commit to sovrn/Prebid.js that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants