Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplelift Bid Adapter: Increase Instream TTL #7455

Merged
merged 19 commits into from
Sep 23, 2021
Merged

Triplelift Bid Adapter: Increase Instream TTL #7455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d65b09a
removes duplicate eids from POST call
nllerandi3lift Feb 19, 2021
0e9deb5
additional tests
nllerandi3lift Feb 22, 2021
224dc40
pubcid support
nllerandi3lift Feb 22, 2021
615e804
Merge pull request #19 from triplelift-internal/TL-19968-pubcid-support
nllerandi3lift Feb 23, 2021
c4b0ff2
Merge remote-tracking branch 'upstream/master'
nllerandi3lift Feb 24, 2021
4565bbc
Merge remote-tracking branch 'upstream/master'
nllerandi3lift Mar 5, 2021
3767f98
Merge remote-tracking branch 'upstream/master'
nllerandi3lift Apr 5, 2021
9d7f1d6
Merge remote-tracking branch 'upstream/master'
nllerandi3lift May 19, 2021
5490b62
Merge remote-tracking branch 'upstream/master'
nllerandi3lift May 21, 2021
2c51a91
Bump elliptic from 6.5.3 to 6.5.4
dependabot[bot] May 21, 2021
767d251
Merge branch 'prebid:master' into master
nllerandi3lift May 25, 2021
cc3ab52
Merge pull request #31 from triplelift-internal/dependabot/npm_and_ya…
Jun 10, 2021
a5f3a37
Revert "Bump elliptic from 6.5.3 to 6.5.4"
dangoldin Jun 10, 2021
3772908
Merge pull request #34 from triplelift-internal/revert-31-dependabot/…
Jun 10, 2021
38f6c04
Merge remote-tracking branch 'upstream/master'
nllerandi3lift Aug 11, 2021
07ba71a
Merge branch 'master' of https://github.com/triplelift-internal/Prebi…
nllerandi3lift Aug 11, 2021
6e94452
Merge branch 'prebid:master' into master
nllerandi3lift Sep 22, 2021
41e1db7
increases instream TTL
nllerandi3lift Sep 22, 2021
87d2f0b
Merge pull request #38 from triplelift-internal/TL-22981-instreamTTL
nllerandi3lift Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/tripleliftBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { config } from '../src/config.js';
const GVLID = 28;
const BIDDER_CODE = 'triplelift';
const STR_ENDPOINT = 'https://tlx.3lift.com/header/auction?';
const BANNER_TIME_TO_LIVE = 300;
const INSTREAM_TIME_TO_LIVE = 3600;
let gdprApplies = true;
let consentString = null;

Expand Down Expand Up @@ -311,14 +313,15 @@ function _buildResponseObject(bidderRequest, bid) {
creativeId: creativeId,
dealId: dealId,
currency: 'USD',
ttl: 300,
ttl: BANNER_TIME_TO_LIVE,
tl_source: bid.tl_source,
meta: {}
};

if (_isInstreamBidRequest(breq)) {
bidResponse.vastXml = bid.ad;
bidResponse.mediaType = 'video';
bidResponse.ttl = INSTREAM_TIME_TO_LIVE;
};

if (bid.advertiser_name) {
Expand Down
2 changes: 2 additions & 0 deletions test/spec/modules/tripleliftBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,8 @@ describe('triplelift adapter', function () {
expect(result).to.have.length(2);
expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0]));
expect(Object.keys(result[1])).to.have.members(Object.keys(expectedResponse[1]));
expect(result[0].ttl).to.equal(300);
expect(result[1].ttl).to.equal(3600);
});

it('should return multiple responses to support SRA', function () {
Expand Down