Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartx Bid Adapter: fix empty title not configurable #7417

Merged
merged 43 commits into from
Sep 15, 2021
Merged

smartx Bid Adapter: fix empty title not configurable #7417

Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
aa0c2de
Add smartclipBidAdapter
May 20, 2020
a4daadc
smartxBidAdapter.js - removed unused variables, removed debug, added …
Skylinar Sep 2, 2020
d87968f
Merge branch 'master' of https://github.com/smartclip-adtech/Prebid.js
Oct 14, 2020
41fb65e
Merge branch 'master' of https://github.com/prebid/Prebid.js
Oct 14, 2020
a34fc49
Merge branch 'master' of https://github.com/prebid/Prebid.js
Oct 27, 2020
f5481d7
Merge branch 'master' of https://github.com/prebid/Prebid.js
Nov 4, 2020
1510b28
Merge commit 'b7ec359ca242ceab4cd0c7e37307247974126e51'
smartclip-adtech Jan 28, 2021
2a965c9
- made outstream player configurable
Skylinar Jan 29, 2021
b577bd3
remove wrong named files
Skylinar Jan 29, 2021
2b96ef1
camelcase
Skylinar Jan 29, 2021
8715820
fix
Skylinar Feb 3, 2021
b55fb7d
Out-Stream render update to SmartPlay 5.2
Skylinar Mar 1, 2021
41ba404
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Mar 1, 2021
1af62e6
ESlint fix
Skylinar Mar 1, 2021
1ef8d74
ESlint fix
Skylinar Mar 1, 2021
9134944
ESlint fix
Skylinar Mar 1, 2021
335b9bd
adjust tests, fixes
Skylinar Mar 5, 2021
1ae18d1
ESlint
Skylinar Mar 5, 2021
f6d4816
adjusted desired bitrate examples
Skylinar Mar 18, 2021
ed40876
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Mar 18, 2021
94b7510
added bid.meta.advertiserDomains support
Skylinar Apr 8, 2021
fc86b71
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Apr 8, 2021
06934f4
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Apr 14, 2021
4861e23
bug fix for numeric elementID outstream render
Skylinar Apr 14, 2021
e7b1277
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar May 7, 2021
da45be6
fix renderer url
Skylinar May 7, 2021
a52eeea
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar May 27, 2021
b2a5a66
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar May 31, 2021
8943657
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar May 31, 2021
06edd1e
support for floors module
Skylinar Jun 1, 2021
1b36a3c
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Jun 1, 2021
c5b25e4
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Jun 10, 2021
d1bd22a
bugfixes to be openRTB 2.5 compliant
Skylinar Jun 10, 2021
2a39091
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Jun 30, 2021
e5916da
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Jul 1, 2021
def250b
update internal renderer usage
Skylinar Jul 1, 2021
cec1e82
remove unused outstream_function logic
Skylinar Jul 1, 2021
e90c67f
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Aug 19, 2021
c0a0139
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Sep 1, 2021
48b6f44
bugfix outstream options for default outstream renderer configuration
Skylinar Sep 1, 2021
effeb19
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Sep 6, 2021
3543835
[PREB-10] fix empty title not configurable
Skylinar Sep 15, 2021
77765b7
Merge branch 'master' of https://github.com/prebid/Prebid.js
Skylinar Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/smartxBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ function createOutstreamConfig(bid) {
smartPlayObj.endingScreen = false;
}

if (confTitle) {
if (confTitle || (typeof bid.renderer.config.outstream_options.title == 'string' && bid.renderer.config.outstream_options.title == '')) {
smartPlayObj.title = confTitle;
}

Expand Down