Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo ID url params, RTD dupe protection, doc update #7204

Merged
merged 6 commits into from
Jul 28, 2021

Conversation

antlauzon
Copy link
Contributor

@antlauzon antlauzon commented Jul 22, 2021

Type of change

  • Bugfix

This is a small update to the Halo code. It adds configurable URL parameters to the ID module, adds array-level data duplication protection to the RTD module, and updates the RTD documentation.

Other information

Halo RTD Module: Enable Per-Bidder Data - #7060
Halo RTD Module: FPD 2.0 Updates & add ID system tests - #6505

@antlauzon
Copy link
Contributor Author

@ChrisHuie this is similar to the last one, a few minor changes to the id & rtd system

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also submit a prebid docs PR for the new url config param?

modules/haloIdSystem.js Show resolved Hide resolved
@antlauzon
Copy link
Contributor Author

@smenzer update docs for url arg and there is a pr for the website here: prebid/prebid.github.io#3154

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer smenzer merged commit b4a04c9 into prebid:master Jul 28, 2021
@MartianTribe
Copy link

prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* halo allow id url config, rtd dedupe array merge, doc update

* add per-bidder dedupe test

* refresh pbjs haloId when available

* doc update

* update docs

* doc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants