-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PubMatic Analytics Adapter: added support for Bidder alias #7153
Conversation
Changed net revenue to True
Syncing with Upstream
Hi @pm-azhar-mulla , I just noticed that these changes will work only if the bidder alias is all lowercase letters: I've tried the following example:
And what I see get sent to your endpoint is |
Removed the code which was converting bidder to lowercase, @pm-harshad-mane you remember any reason why were converting bidder to lowercase? |
Can someone please re-run the test jobs (CI) |
@pm-azhar-mulla if you can confirm that we can move forward with the removal of lowercase conversion (for bidder name), I can merge this. |
Hello @aleksatr , @pm-azhar-mulla |
* Changed net revenue to True * Added support for bidderAlias * Removed the code converting bidder to lowercase Co-authored-by: Azhar <[email protected]>
Type of change
Description of change
Added support for Bidder alias in pubmaticAnalyticsAdapter.
Added a new field "bc" to log the bidder code for adapter.