-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smaato bid adapter: adpod support added #7101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enigo
force-pushed
the
PREB-17_Q_ad_podding_support
branch
from
June 25, 2021 08:25
42aa5ba
to
f19a1af
Compare
Fawke
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…r adpod adunits differently
Enigo
force-pushed
the
PREB-17_Q_ad_podding_support
branch
from
June 29, 2021 10:11
f19a1af
to
a64c734
Compare
hey @Fawke, yep, sure, just rebased from the latest master |
and it is failing still :( |
prebidtappx
pushed a commit
to prebidtappx/Prebid.js
that referenced
this pull request
Nov 15, 2021
* Smaato bid adapter: Refactor tests * Smaato bid adapter: Rework bid request validation to handle params for adpod adunits differently * Smaato bid adapter: Pass adpod adunit parameters to Smaatos server * Smaato bid adapter: Add response interpretation for adpods * Smaato bid adapter: Bump adapter version * Smaato bid adapter: finalizing OTT support Co-authored-by: Jonas Gresens <[email protected]> Co-authored-by: Ruslan Sibgatullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Adding OTT aka adpodding support for Smaato adapter.
Similar change will be done on prebid server side as well.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
--> Smaato: update documentation prebid.github.io#3062
Other information