Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaato bid adapter: adpod support added #7101

Merged
merged 6 commits into from
Jun 30, 2021

Conversation

Enigo
Copy link
Contributor

@Enigo Enigo commented Jun 25, 2021

Type of change

  • Feature

Description of change

Adding OTT aka adpodding support for Smaato adapter.
Similar change will be done on prebid server side as well.

  • contact email of the adapter’s maintainer: [email protected]
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke added the LGTM label Jun 28, 2021
@Fawke
Copy link
Contributor

Fawke commented Jun 29, 2021

Hi @Enigo, Can you please sync with master, we merged #7104 to fix some failing circle-ci tests. Thank you.

@Enigo Enigo force-pushed the PREB-17_Q_ad_podding_support branch from f19a1af to a64c734 Compare June 29, 2021 10:11
@Enigo
Copy link
Contributor Author

Enigo commented Jun 29, 2021

hey @Fawke, yep, sure, just rebased from the latest master

@Enigo
Copy link
Contributor Author

Enigo commented Jun 29, 2021

and it is failing still :(

@Fawke Fawke merged commit 072d612 into prebid:master Jun 30, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* Smaato bid adapter: Refactor tests

* Smaato bid adapter: Rework bid request validation to handle params for adpod adunits differently

* Smaato bid adapter: Pass adpod adunit parameters to Smaatos server

* Smaato bid adapter: Add response interpretation for adpods

* Smaato bid adapter: Bump adapter version

* Smaato bid adapter: finalizing OTT support

Co-authored-by: Jonas Gresens <[email protected]>
Co-authored-by: Ruslan Sibgatullin <[email protected]>
@Enigo Enigo deleted the PREB-17_Q_ad_podding_support branch September 29, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants