Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Ad Server: add advertiser domain support and read more mediaTypes.video params #6944

Merged

Conversation

lowendavid
Copy link
Contributor

Type of change

  • Feature

Description of change

Two features are added here:

Firstly #6512
This change updates the smartadserver bidder to read more from the mediaTypes.video params.

Secondly #6650
Added meta.advertiserDomains according to the above issue and to be compatible with the next newer version.

@mlapeyre3
Copy link

Hello @patmmccann, please find our PR related to the discussion we had on #6611 to support Prebid 5.x

  • Our adapter supports two video parameters (the rest is handled server-side) and you will notice that we convert the oRTB values to our bidder-specific values (one day I really need to convert our values to the standard ones ahah)
  • we support return advertiserDomains yet, but we provided the placeholder to be compatible with Prebid 5

Thanks!

@patmmccann
Copy link
Collaborator

Thanks so much for this, we really appreciate the quick turn around as we're hoping to release 5 on Wednesday!

@ChrisHuie ChrisHuie self-requested a review June 4, 2021 16:53
@ChrisHuie ChrisHuie self-assigned this Jun 4, 2021
@ChrisHuie
Copy link
Collaborator

@lowendavid @mlapeyre3 can you please add unit test coverage to this pr 🙏

@ChrisHuie ChrisHuie changed the title Smart ad server version5.0 compliance Smart Ad Server: add advertiser domain support and read more mediaTypes.video params Jun 4, 2021
@ChrisHuie ChrisHuie merged commit 20e0ef8 into prebid:master Jun 7, 2021
@krzysztofequativ krzysztofequativ deleted the SmartAdServer-Version5.0Compliance branch January 13, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants