-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart Ad Server: add advertiser domain support and read more mediaTypes.video params #6944
Merged
ChrisHuie
merged 14 commits into
prebid:master
from
smartadserver:SmartAdServer-Version5.0Compliance
Jun 7, 2021
Merged
Smart Ad Server: add advertiser domain support and read more mediaTypes.video params #6944
ChrisHuie
merged 14 commits into
prebid:master
from
smartadserver:SmartAdServer-Version5.0Compliance
Jun 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @patmmccann, please find our PR related to the discussion we had on #6611 to support Prebid 5.x
Thanks! |
Thanks so much for this, we really appreciate the quick turn around as we're hoping to release 5 on Wednesday! |
@lowendavid @mlapeyre3 can you please add unit test coverage to this pr 🙏 |
ChrisHuie
changed the title
Smart ad server version5.0 compliance
Smart Ad Server: add advertiser domain support and read more mediaTypes.video params
Jun 4, 2021
ChrisHuie
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Two features are added here:
Firstly #6512
This change updates the smartadserver bidder to read more from the mediaTypes.video params.
Secondly #6650
Added meta.advertiserDomains according to the above issue and to be compatible with the next newer version.