-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eTarget Bid Adapter: add "getMetaData" function to adapter #6830
Conversation
getMetaData used to gether useful information from publisher site
@etargetse looks like that worked :) Don't forget to add back in the test too if you could |
bidder: 'etarget', | ||
gdpr: gdprObject | ||
}; | ||
|
||
function getMetaData() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the request here, please also gather this info from the ortb2 object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
problem is that ortb2 is available only when portal will fill info into this object, what we want to achieve is to gather info every time our adapter will be used. Is there any leagal/technical problem with our implementation? Why we cant collect info by ourselfs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix #6650 ; it's being enforced imminently
I started working on this feature but i need to create new fork because when i edit things on old fork then circleci have always problems with somethink. But i cant create new fork before this pull requerst is closed. So can you please merge this new feature if there is no real reason why not to merge? THANKS.
Please also fix #6650 ; it's being enforced imminently |
working on it |
@ChrisHuie @patmmccann Hey guys, we are in bit hurry, please if our code has no legal or coding errors can you please review our adapter and merge it into master repo? Thanks. |
@etargetse you still need to add back the unit tests before this pr can get approved please |
i am closing this pull request because when i update test script then it will fail because this new feature is not included |
getMetaData used to gether useful information from publisher site
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information