-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ucfunnel Bid Adapter: add support Price Floors Module #6806
Conversation
2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block
Merge the latest changes 9/25/2017
@jackhsiehucf browserstack seems to be hanging on this pr and another one I have come across and that is messing with testing. Trying to figure out what exactly the issue is. |
Thanks for this PR, I removed changes to your adapter from #6804 |
if (typeof bid.getFloor === 'function') { | ||
var bidFloor = bid.getFloor({ | ||
currency: CURRENCY, | ||
mediaType: getMediaType(mediaTypes), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On multiformat unit, this appears to always set the video floor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann Does multiformat unit mean that adUnits support multiple mediaType ?
Like support banner and video in the same adUnits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I update the commit to fix the banner bid floor problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann any comment about the update commit?
…FilterStatus' into PBID-96_requestFilterStatus * origin/parrableIdSystem/PBID-96_requestFilterStatus: (63 commits) Smaato bid adapter: Rework multi imp support (prebid#6814) Adot Bid Adapter: add the advertising domains support (prebid#6876) Update Adtelligent, Adtarget, ViewDeos adapters to support adomain (prebid#6917) LockerDome Bid Adapter: support for meta.advertiserDomains (prebid#6921) Sublime Bid Adapter : Add support for meta.advertiserDomains (prebid#6920) Brightcom Bid Adapter: use getFloor function (prebid#6918) AdYouLike Bidder: Handle advertiser domains (prebid#6916) relaido Bid Adapter: Add meta OBJ to BidResponse (prebid#6914) Jixie Bid Adapter: add support for advertiserDomains (prebid#6898) Onomagic Bid Adapter: use getFloor function (prebid#6907) Sharethrough Bid Adapter: Use getFloor module for Prebid 5.0 compliance (prebid#6874) Accept outstream renderers defined in mediatype for PBS (prebid#6896) Yieldmo Bid Adapter: read video parameters from the ad unit (prebid#6873) smartx Bid Adapter: Add support for Floors Module (prebid#6902) add support for advertiser domains (prebid#6908) Onomagic Bid Adapter: handle meta.advertiserDomains (prebid#6906) Brightcom Bid Adapter: handle meta.advertiserDomains (prebid#6905) ucfunnel Bid Adapter: add support Price Floors Module (prebid#6806) eTarget Bid Adapter: add "getMetaData" function to adapter, support for advertiserDomains (prebid#6901) AdagioBidAdapter: support priceFloors module (prebid#6867) ...
* Add a new ucfunnel Adapter and test page * Add a new ucfunnel Adapter and test page * 1. Use prebid lib in the repo to keep updated 2. Replace var with let 3. Put JSON.parse(JSON.stringify()) into try catch block * utils.getTopWindowLocation is a function * Change to modules from adapters * Migrate to module design * [Dev Fix] Remove width and height which can be got from ad unit id * Update ucfunnelBidAdapter to fit into new spec * Correct the endpoint. Fix the error of query string * Add test case for ucfunnelBidAdapter * Fix lint error * Update version number * Combine all checks on bid request * Add GDPR support for ucfunnel adapter * Add in-stream video and native support for ucfunnel adapter * Remove demo page. Add more test cases. * Change request method from POST to GET * Remove unnecessary comment * Support vastXml and vastUrl for video request * update TTL to 30 mins * Avoid using arrow function which is not discuraged in mocha * ucfunnel tdid support * ucfunnel fix error message in debug mode * ucfunnel adapter add bidfloor parameter * ucfunnel adapter support CCPA * ucfunnel adapter native support clicktrackers * ucfunnel adapter change cookie sync setting * ucfunnel adapter update request parameter * Update ucfunnelBidAdapter * ucfunnel adapter add currency in ad response * ucfunnel adapter support uid2 * ucfunnel Bid Adapter: add support for FLoC and Verizon Media ConnectID * ucfunnel Bid Adapter: add support Price Floors Module Co-authored-by: root <[email protected]> Co-authored-by: Ryan Chou <[email protected]> Co-authored-by: ucfunnel <[email protected]> Co-authored-by: jack.hsieh <[email protected]>
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information