Criteo Bid Adapter: update adapter to use mediaTypes.video instead of custom parameters #6778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
patmmccann
reviewed
May 18, 2021
modules/criteoBidAdapter.js
Outdated
| @@ -311,15 +311,14 @@ function buildCdbRequest(context, bidRequests, bidderRequest) { | |||
| mimes: bidRequest.mediaTypes.video.mimes, | |||
| protocols: bidRequest.mediaTypes.video.protocols, | |||
| maxduration: bidRequest.mediaTypes.video.maxduration, | |||
| api: bidRequest.mediaTypes.video.api | |||
| api: bidRequest.mediaTypes.video.api, | |||
| skip: bidRequest.mediaTypes.video.skippable || bidRequest.params.video.skip, | |||
There was a problem hiding this comment.
Thanks @patmmccann , fixed
patmmccann
requested changes
May 18, 2021
leonardlabat
force-pushed
the
criteo_video
branch
from
adaa188 to
94748f7
Compare
leonardlabat
force-pushed
the
criteo_video
branch
from
94748f7 to
02e2024
Compare
patmmccann
approved these changes
May 19, 2021
|
@leonardlabat could you also address #6650 please |
|
hey @leonardlabat wanted to follow up here - will you be able to add the adomain stub in the next week? |
|
it got merged already #6915 |
|
Yep exactly |
|
perfect thank you both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Updated adapter to use mediaTypes.video instead of custom parameters.
Reading from custom parameters is kep for now to ensure backward compatibility. Documentation will be updated once PBJS 5.0 will be released.