Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBJS Core - Validate adunit page position / PBS and RP adapters updates to pass pos in banner and video requests #6616

Merged
merged 2 commits into from
May 3, 2021

Conversation

mmoschovas
Copy link
Contributor

@mmoschovas mmoschovas commented Apr 19, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • PBJS Core update to include validation of pos value on adunit
  • PBS adapter update to include pos value on banner requests (video already included)
  • RP adapter update to use pos bidder params.pos or mediaType.banner.pos value in banner request (video already passed properly)

Issue: #5578

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Update to PBS adapter to pass pos in banner requests
24 verbose exit [ 1, true ]
- PBS adapter update to pass pos value on banner requests
- RP adapter update to check mediaTypes.banner.pos to set value as well as bidder params (bidder params will override ad unit level)
Copy link
Contributor

@ncolletti ncolletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could use a docs PR to add a note about this in the Ad Unit Reference page. Also adding another reviewer since this contains core files.

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but we will need a Docs PR as well.

@bretg
Copy link
Collaborator

bretg commented Apr 28, 2021

Docs PR prebid/prebid.github.io#2917

@bretg bretg removed the needs docs label Apr 28, 2021
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncolletti ncolletti merged commit 05f86d7 into prebid:prebid-5.0 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants