Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adkernel Bid Adapter: add new alias #6608

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Adkernel Bid Adapter: add new alias #6608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/adkernelBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const NATIVE_INDEX = NATIVE_MODEL.reduce((acc, val, idx) => {
export const spec = {
code: 'adkernel',
gvlid: GVLID,
aliases: ['headbidding', 'adsolut', 'oftmediahb', 'audiencemedia', 'waardex_ak', 'roqoon', 'andbeyond', 'adbite', 'houseofpubs', 'torchad', 'stringads', 'bcm'],
aliases: ['headbidding', 'adsolut', 'oftmediahb', 'audiencemedia', 'waardex_ak', 'roqoon', 'andbeyond', 'adbite', 'houseofpubs', 'torchad', 'stringads', 'bcm', 'engageadx'],
supportedMediaTypes: [BANNER, VIDEO, NATIVE],

/**
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/adkernelBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ describe('Adkernel adapter', function () {

describe('adapter configuration', () => {
it('should have aliases', () => {
expect(spec.aliases).to.have.lengthOf(12);
expect(spec.aliases).to.be.an('array').that.is.not.empty;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why not bump it up to 13

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will ease new alias adding to a person not familiar with javascript development (some of our clients have struggled to add a new alias because of this explicit check). Moreover, the alias list is a kind of constant, so it's a bit strange to check a constant value in a unit test. With this change, it's become more logical as we only check the adaptor interface contract fulfillment.

});
});

Expand Down