Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlueBillyWig Bid Adapter: add renderer customization options #6540

Merged
merged 17 commits into from
Apr 12, 2021
Merged

BlueBillyWig Bid Adapter: add renderer customization options #6540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1ae44aa
add Blue Billywig adapter
K-JBoon Apr 14, 2020
263aeae
Blue Billywig Adapter - update according to review feedback
K-JBoon Apr 21, 2020
b52c832
Blue Billywig Adapter - update to try and pass CircleCI
K-JBoon Apr 29, 2020
4772e9b
Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...
K-JBoon May 5, 2020
024f530
Update bluebillywigBidAdapter test parameters to match renderer to re…
K-JBoon May 7, 2020
e1dd5ac
Blue Billywig - Also pass through site config with OpenRTB request
K-JBoon May 20, 2020
26c625f
Blue Billywig - sync with master, resolve merge conflict
K-JBoon May 20, 2020
c98114c
add Blue Billywig adapter
K-JBoon Apr 14, 2020
119e6af
Blue Billywig Adapter - update according to review feedback
K-JBoon Apr 21, 2020
a4b25e3
Blue Billywig Adapter - update to try and pass CircleCI
K-JBoon Apr 29, 2020
3c66827
Remove the last for .. of in bluebillywigBidAdapter.js, hopefully...
K-JBoon May 5, 2020
7481144
Code quality update, always hit user syncs, improved video params
Aug 10, 2020
30aebb6
Merge branch 'master' of github.com:prebid/Prebid.js
K-JBoon Apr 7, 2021
0750c3b
Merge branch 'master' of github.com:bluebillywig/Prebid.js
K-JBoon Apr 7, 2021
50c2111
Remove unnecessary export
K-JBoon Apr 7, 2021
8775a8e
Add rendererSettings param to bluebillywig adapter
K-JBoon Apr 7, 2021
adc2f89
Kick off CircleCi tests manually
ChrisHuie Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/bluebillywigBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const BB_CONSTANTS = {
const getConfig = config.getConfig;

// Helper Functions
export const BB_HELPERS = {
const BB_HELPERS = {
addSiteAppDevice: function(request, pageUrl) {
if (typeof getConfig('app') === 'object') request.app = getConfig('app');
else {
Expand Down Expand Up @@ -151,7 +151,7 @@ const BB_RENDERER = {
const ele = document.getElementById(bid.adUnitCode); // NB convention
const renderer = find(window.bluebillywig.renderers, r => r._id === rendererId);

if (renderer) renderer.bootstrap(config, ele);
if (renderer) renderer.bootstrap(config, ele, bid.rendererSettings || {});
else utils.logWarn(`${BB_CONSTANTS.BIDDER_CODE}: Couldn't find a renderer with ${rendererId}`);
},
newRenderer: function(rendererUrl, adUnitCode) {
Expand Down Expand Up @@ -235,6 +235,11 @@ export const spec = {
return false;
}

if (bid.params.hasOwnProperty('rendererSettings') && (bid.params.rendererSettings === null || typeof bid.params.rendererSettings !== 'object')) {
utils.logError(`${BB_CONSTANTS.BIDDER_CODE}: params.rendererSettings must be of type object. Rejecting bid: `, bid);
return false;
}

if (bid.hasOwnProperty('mediaTypes') && bid.mediaTypes.hasOwnProperty(VIDEO)) {
if (!bid.mediaTypes[VIDEO].hasOwnProperty('context')) {
utils.logError(`${BB_CONSTANTS.BIDDER_CODE}: no context specified in bid. Rejecting bid: `, bid);
Expand Down Expand Up @@ -330,6 +335,7 @@ export const spec = {
bid.publicationName = bidParams.publicationName;
bid.rendererCode = bidParams.rendererCode;
bid.accountId = bidParams.accountId;
bid.rendererSettings = bidParams.rendererSettings;

const rendererUrl = BB_HELPERS.getRendererUrl(bid.publicationName, bid.rendererCode);
bid.renderer = BB_RENDERER.newRenderer(rendererUrl, bid.adUnitCode);
Expand Down
19 changes: 19 additions & 0 deletions test/spec/modules/bluebillywigBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,25 @@ describe('BlueBillywigAdapter', () => {
bid.params.video = void (0);
expect(spec.isBidRequestValid(bid)).to.equal(false);
});

it('should fail if rendererSettings is specified but is not an object', () => {
const bid = deepClone(baseValidBid);

bid.params.rendererSettings = null;
expect(spec.isBidRequestValid(bid)).to.equal(false);

bid.params.rendererSettings = 'string';
expect(spec.isBidRequestValid(bid)).to.equal(false);

bid.params.rendererSettings = 123;
expect(spec.isBidRequestValid(bid)).to.equal(false);

bid.params.rendererSettings = false;
expect(spec.isBidRequestValid(bid)).to.equal(false);

bid.params.rendererSettings = void (0);
expect(spec.isBidRequestValid(bid)).to.equal(false);
});
});

describe('buildRequests', () => {
Expand Down